Skip to contentSkip to conversation

rtc uie emulation deadlocks

BUG Russell King 4 participants 5 messages Aug 11, 2008 – Aug 20, 2008

lore
Share & tools
lore
#0 lore raw

With CONFIG_RTC_INTF_DEV_UIE_EMUL=y, hwclock deadlocks in rtc_read_time due to:

static long rtc_dev_ioctl(struct file *file,
unsigned int cmd, unsigned long arg)

{
        err = mutex_lock_interruptible(&rtc->ops_lock);
        if (err)
                return err;
...
        switch (cmd) {
#ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL
        case RTC_UIE_OFF:
                clear_uie(rtc);
                break;

        case RTC_UIE_ON:
                err = set_uie(rtc);

#endif
}

static int set_uie(struct rtc_device *rtc)

{
        err = rtc_read_time(rtc, &tm);

...

int rtc_read_time(struct rtc_device *rtc, struct rtc_time *tm)

{
        err = mutex_lock_interruptible(&rtc->ops_lock);

So we try to take the same lock twice... Not good.

The locking looks a rather random in there, so I'm not going to try to create a patch.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#1 lore raw
Quoted 26 lines · On Mon, 11 Aug 2008 14:43:39 +0100 Russell King <[email protected]>…

With CONFIG_RTC_INTF_DEV_UIE_EMUL=y, hwclock deadlocks in rtc_read_time due to:

static long rtc_dev_ioctl(struct file *file,
unsigned int cmd, unsigned long arg)

{
        err = mutex_lock_interruptible(&rtc->ops_lock);
        if (err)
                return err;
...
        switch (cmd) {
#ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL
        case RTC_UIE_OFF:
                clear_uie(rtc);
                break;

        case RTC_UIE_ON:
                err = set_uie(rtc);

#endif
}

static int set_uie(struct rtc_device *rtc)

{
        err = rtc_read_time(rtc, &tm);

...

Quoted 9 lines

int rtc_read_time(struct rtc_device *rtc, struct rtc_time *tm)

{
        err = mutex_lock_interruptible(&rtc->ops_lock);

So we try to take the same lock twice... Not good.

The locking looks a rather random in there, so I'm not going to try to create a patch.

Looks like this was caused by

commit 5ad31a575157147b43fa84ef1e21471661653878

Author: David Brownell <[email protected]>
Date:   Wed Jul 23 21:30:33 2008 -0700

rtc: remove BKL for ioctl()

#2 lore raw
Quoted 7 lines · --- Andrew Morton
Quoted 3 lines · On Mon, 11 Aug 2008 14:43:39 +0100 Russell King <[email protected]>…

The locking looks a rather random in there, so I'm not going to try to create a patch.

Quoted 7 lines

Looks like this was caused by

commit 5ad31a575157147b43fa84ef1e21471661653878

Author: David Brownell <[email protected]>
Date:   Wed Jul 23 21:30:33 2008 -0700

rtc: remove BKL for ioctl()

I'm sure I saw someone else's fixup patch for that a couple weeks ago. (Looks). Yes:

http://groups.google.com/group/rtc-linux/browse_thread/thread/ad65b883739f8c92#

#3 lore raw
Quoted 16 lines · On Tue, 19 Aug 2008 10:12:04 -0700 (PDT) David Brownell <[email protected]>…
Quoted 13 lines · --- Andrew Morton
Quoted 3 lines · On Mon, 11 Aug 2008 14:43:39 +0100 Russell King <[email protected]>…

The locking looks a rather random in there, so I'm not going to try to create a patch.

Looks like this was caused by

commit 5ad31a575157147b43fa84ef1e21471661653878

Author: David Brownell <[email protected]>
Date:   Wed Jul 23 21:30:33 2008 -0700
Quoted 6 lines
Quoted 1 line

rtc: remove BKL for ioctl()

I'm sure I saw someone else's fixup patch for that a couple weeks ago. (Looks). Yes:

http://groups.google.com/group/rtc-linux/browse_thread/thread/ad65b883739f8c92#

argh, so a fix for a serious regression has been languishing in the backwaters of the rtc list for two weeks.

Guys, please: regressions are serious, top-priority emergencies. We drop everything and run around with our hair on fire when we hear about one (don't we?). Please, if you have a report of a regression or a fix for one, Cc: everyone in the world on it.

I'd prefer not to go fishing through HTML to piece that patch together, but as my hair is on fire I guess I'd better do so.

#4 lore raw
Quoted 5 lines · Andrew Morton
Quoted 4 lines

I'm sure I saw someone else's fixup patch for that a couple weeks ago. (Looks). Yes:

http://groups.google.com/group/rtc-linux/browse_thread/thread/ad65b883739f8c92#

Quoted 7 lines

argh, so a fix for a serious regression has been languishing in the backwaters of the rtc list for two weeks.

Guys, please: regressions are serious, top-priority emergencies. We drop everything and run around with our hair on fire when we hear about one (don't we?). Please, if you have a report of a regression or a fix for one, Cc: everyone in the world on it.

Oh, I had thought I CC-ed it to LKML but actually I didn't. Thank you for catching it up anyway.

---
Atsushi Nemoto