Skip to contentSkip to conversation

bridge: show offload settings

PATCH Applied Stephen Hemminger 3 participants 6 messages Aug 15, 2008 – Aug 16, 2008

Subsystems (4)
Networking Network drivers Ethernet bridge Bonding driver
lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 bridge: show offload settings

Add more ethtool generic operations to dump the bridge offload settings.

Signed-off-by Stephen Hemminger <[email protected]>
drivers/net/bonding/bond_main.c +6 -0
@@ -4493,6 +4493,12 @@ static void bond_ethtool_get_drvinfo(str
 
 static const struct ethtool_ops bond_ethtool_ops = {
 	.get_drvinfo		= bond_ethtool_get_drvinfo,
+	.get_link		= ethtool_op_get_link,
+	.get_tx_csum		= ethtool_op_get_tx_csum,
+	.get_sg			= ethtool_op_get_sg,
+	.get_tso		= ethtool_op_get_tso,
+	.get_ufo		= ethtool_op_get_ufo,
+	.get_flags		= ethtool_op_get_flags,
 };
 
 /*
#2 lore raw
Quoted 9 lines · David Miller

From: Stephen Hemminger <[email protected]>
Date: Fri, 15 Aug 2008 10:02:59 -0700

Quoted 4 lines

Add more ethtool generic operations to dump the bridge offload settings.

Signed-off-by Stephen Hemminger <[email protected]>

Applied, thanks.

I might be confused, but it looks like Stephen included the
wrong patch; it references "bridge" in the comments, but duplicates his earlier patch for bonding:

Date: Fri, 15 Aug 2008 10:02:59 -0700
From: Stephen Hemminger <[email protected]>
To: David Miller <[email protected]>
Cc: [email protected]
Subject: [PATCH] bridge: show offload settings
Organization: Vyatta

Add more ethtool generic operations to dump the bridge offload settings.

Signed-off-by Stephen Hemminger <[email protected]>
drivers/net/bonding/bond_main.c +6 -0
@@ -4493,6 +4493,12 @@ static void bond_ethtool_get_drvinfo(str
 
 static const struct ethtool_ops bond_ethtool_ops = {
 	.get_drvinfo		= bond_ethtool_get_drvinfo,
+	.get_link		= ethtool_op_get_link,
+	.get_tx_csum		= ethtool_op_get_tx_csum,
+	.get_sg			= ethtool_op_get_sg,
+	.get_tso		= ethtool_op_get_tso,
+	.get_ufo		= ethtool_op_get_ufo,
+	.get_flags		= ethtool_op_get_flags,
 };
 

	-J

---
-Jay Vosburgh, IBM Linux Technology Center, [email protected]

author
#3 lore raw

Here is the correct patch to add more offload settings for bridge. Earlier was the bonding one (sorry).

Signed-off-by Stephen Hemminger <[email protected]>
net/bridge/br_device.c +10 -5
@@ -148,11 +148,16 @@ static int br_set_tx_csum(struct net_dev
 }
 
 static struct ethtool_ops br_ethtool_ops = {
-	.get_drvinfo = br_getinfo,
-	.get_link = ethtool_op_get_link,
-	.set_sg = br_set_sg,
-	.set_tx_csum = br_set_tx_csum,
-	.set_tso = br_set_tso,
+	.get_drvinfo    = br_getinfo,
+	.get_link	= ethtool_op_get_link,
+	.get_tx_csum	= ethtool_op_get_tx_csum,
+	.set_tx_csum 	= br_set_tx_csum,
+	.get_sg		= ethtool_op_get_sg,
+	.set_sg		= br_set_sg,
+	.get_tso	= ethtool_op_get_tso,
+	.set_tso	= br_set_tso,
+	.get_ufo	= ethtool_op_get_ufo,
+	.get_flags	= ethtool_op_get_flags,
 };
 
 void br_dev_setup(struct net_device *dev)
maintainer
#5 lore raw
In reply to Jay Vosburgh

From: Jay Vosburgh <[email protected]>
Date: Fri, 15 Aug 2008 15:59:43 -0700

Quoted 8 lines
Quoted 6 lines · David Miller

From: Stephen Hemminger <[email protected]>
Date: Fri, 15 Aug 2008 10:02:59 -0700

Quoted 3 lines

Add more ethtool generic operations to dump the bridge offload settings.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Stephen Hemminger <[email protected]>

Applied, thanks.

I might be confused, but it looks like Stephen included the
wrong patch; it references "bridge" in the comments, but duplicates his earlier patch for bonding:

This has been sorted out, thanks Jay.