Skip to contentSkip to conversation

security.h: fix build failure

PATCH In review Alexander Beregalov 3 participants 4 messages Aug 17, 2008 Security (LSM)

lore
Share & tools
lore

Alexander Beregalov

author
#0 lore raw

PATCH 1/1 security.h: fix build failure

From: Alexander Beregalov <[email protected]>

security.h: fix build failure

include/linux/security.h: In function 'security_ptrace_traceme':
include/linux/security.h:1760: error: 'parent' undeclared (first use in this function)

Signed-off-by Alexander Beregalov <[email protected]>

---

 include/linux/security.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/security.h +1 -1
index 2ee5ecf..80c4d00 100644
@@ -1755,7 +1755,7 @@ static inline int security_ptrace_may_access(struct task_struct *child,
 	return cap_ptrace_may_access(child, mode);
 }
 
-static inline int security_ptrace_traceme(struct task_struct *child)
+static inline int security_ptrace_traceme(struct task_struct *parent)
 {
 	return cap_ptrace_traceme(parent);
 }
Tested-by on v1 1/1
#1 lore raw
Quoted 6 lines · Alexander Beregalov

From: Alexander Beregalov <[email protected]>

security.h: fix build failure

include/linux/security.h: In function 'security_ptrace_traceme':
include/linux/security.h:1760: error: 'parent' undeclared (first use in this function)

i just triggered this too on today's -git with this config:

http://redhat.com/~mingo/misc/config-Sun_Aug_17_11_02_11_CEST_2008.bad

and your fix solves it.

Tested-by Ingo Molnar <[email protected]>

Ingo

maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Alexander Beregalov
Quoted 9 lines · Alexander Beregalov

From: Alexander Beregalov <[email protected]>

security.h: fix build failure

include/linux/security.h: In function 'security_ptrace_traceme':
include/linux/security.h:1760: error: 'parent' undeclared (first use in this function)

Signed-off-by Alexander Beregalov <[email protected]>
Acked-by James Morris <[email protected]>
Quoted 19 lines

---

 include/linux/security.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/security.h +1 -1
index 2ee5ecf..80c4d00 100644
@@ -1755,7 +1755,7 @@ static inline int security_ptrace_may_access(struct task_struct *child,
 	return cap_ptrace_may_access(child, mode);
 }
 
-static inline int security_ptrace_traceme(struct task_struct *child)
+static inline int security_ptrace_traceme(struct task_struct *parent)
 {
 	return cap_ptrace_traceme(parent);
 }
Signature · 2 lines
James Morris
<[email protected]>
maintainer
#3 lore raw

There's a pullable version here:

The following changes since commit
b09c3e3f1710b554348c98e78fbf4a661918779a:
Huang Weiyi (1):
removed unused #include <version.h>

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6 for-linus

Alexander Beregalov (1):
security.h: fix build failure

 include/linux/security.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Signature · 2 lines
James Morris
<[email protected]>