Skip to contentSkip to conversation

KVM modules break emergency reboot

Bug 11219 Avi Kivity 2 participants 2 messages Aug 18, 2008 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Avi Kivity

author
#1 lore raw

(copying mingo)

(context: sysrq-B with kvm-intel.ko loaded doesn't work. on my machine, it kills the sata interface, but the processor and network keeps working)

Strangely, the specs say:

Quoted 3 lines

• The INIT signal is blocked whenever a logical processor is in VMX root operation. It is not blocked in VMX non-root operation. Instead, INITs cause VM exits (see Section 21.3, “Other Causes of VM Exits”).

So INIT (which is wired to the triple-fault processor output, it seems, rather than RESET) is blocked and the machine is not reset completely.

So we need to disable vmx during native_machine_emergency_restart(). There are at least three ways of doing this:

- add a vmxoff sequence (with an exception handler) to native_machine_emergency_restart(). while simplest, this will not unblock INIT for other cpus

- add an emergency_restart notifier_block, and have kvm subscribe. This has the disadvantage of being slightly complex, opening a tiny race (emergency restart during kvm module initialization), and requiring IPIs during emergency restart.

- move vmxon/vmxoff management out of the kvm module and into x86 core. Bloats the core but reduces complexity. IPIs still required.

I think the notifier block is the way to go. Ingo, let me know what you prefer.

Signature · 1 line
error compiling committee.c: too many arguments to function
#2 lore raw
Quoted 28 lines · Avi Kivity

(copying mingo)

(context: sysrq-B with kvm-intel.ko loaded doesn't work. on my machine, it kills the sata interface, but the processor and network keeps working)

Strangely, the specs say:

Quoted 5 lines

• The INIT signal is blocked whenever a logical processor is in VMX root operation.
It is not blocked in VMX non-root operation. Instead, INITs cause VM exits (see
Section 21.3, “Other Causes of VM Exits”).

So INIT (which is wired to the triple-fault processor output, it seems, rather than RESET) is blocked and the machine is not reset completely.

So we need to disable vmx during native_machine_emergency_restart(). There are at least three ways of doing this:

- add a vmxoff sequence (with an exception handler) to native_machine_emergency_restart(). while simplest, this will not unblock INIT for other cpus

- add an emergency_restart notifier_block, and have kvm subscribe. This has the disadvantage of being slightly complex, opening a tiny race (emergency restart during kvm module initialization), and requiring IPIs during emergency restart.

Quoted 5 lines

- move vmxon/vmxoff management out of the kvm module and into x86 core. Bloats the core but reduces complexity. IPIs still required.

I think the notifier block is the way to go. Ingo, let me know what you prefer.

notifier should be OK i think - sysrq-b is an emergency mechanism after all.

btw., "echo b > /proc/sysrq-trigger" never worked reliably for me with KVM also loaded.

Ingo