fix hangup during boot when USB is used.
cover fix hangup during boot when USB is used.
A recent commit (936897d4d1365452bbbdf8430db5e7769ef08d38) enabled the usb_stop() command in common/cmd_bootm.c which was not enabled for some time, because no board did actually set the CFG_CMD_USB flag. So, now the usb_stop() is executed before loading the linux kernel, which will result in a hangup during boot when USB has been started and stopped already (on AT91SAM).
PATCH 1/1 Make usb-stop() safe to call multiple times in a row.
An embedded and charset-unspecified text was scrubbed...
Name: make-usb-stop-safe-to-call-multiple-times.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20080820/fc8d969f/attachment.txt
PATCH 1/1 Make usb-stop() safe to call multiple times in a row.
Quoted 12 lines · Remy Bohmer
A recent commit (
936897d4d1365452bbbdf8430db5e7769ef08d38) enabled theusb_stop()command incommon/cmd_bootm.cwhich was not enabled for some time, because no board did actually set theCFG_CMD_USBflag. So, now theusb_stop()is executed before loading the linux kernel.However, the
usb_ohcidriver hangs up (at least on AT91SAM) if the driver is stopped twice (e.g. the peripheral clock is stopped on AT91). If some other piece of code callsusb_stop()before the bootm command, this command will hangup the system during boot.
(usb start and stop is typically used while booting from usb memory stick)
Quoted 7 lines
But, stopping the usb stack twice is useless anyway, and a flag already existed that kept track on the usb_init()/usb_stop() calls. So, we now check if the usb stack is really started before we stop it.
This problem is now fixed in both the upper as low-level layer.
Signed-off-by Remy Bohmer <[email protected]>
Wolfgang, please apply!
Best regards
Markus
Signature · 3 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de")
PATCH 1/1 Make usb-stop() safe to call multiple times in a row.
Dear Markus =?iso-8859-1?Q?Klotzb=FCcher?=,
Quoted 8 lines · In message <20080909143500.GA11987@lisa> you wrote:
Quoted 4 lines
This problem is now fixed in both the upper as low-level layer.
Signed-off-by Remy Bohmer <[email protected]>Wolfgang, please apply!
Done. Thanks!
Best regards,
Wolfgang Denk
Signature · 8 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Many companies that have made themselves dependent on [the equipment
of a certain major manufacturer] (and in doing so have sold their
soul to the devil) will collapse under the sheer weight of the un-
mastered complexity of their data processing systems.
-- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5PATCH 1/1 Make usb-stop() safe to call multiple times in a row.
In reply to Remy BohmerDear Remy Bohmer,
Quoted 16 lines · In message <[email protected]>> you wrote:
A recent commit (
936897d4d1365452bbbdf8430db5e7769ef08d38) enabled theusb_stop()command incommon/cmd_bootm.cwhich was not enabled for some time, because no board did actually set theCFG_CMD_USBflag. So, now theusb_stop()is executed before loading the linux kernel.However, the
usb_ohcidriver hangs up (at least on AT91SAM) if the driver is stopped twice (e.g. the peripheral clock is stopped on AT91). If some other piece of code callsusb_stop()before the bootm command, this command will hangup the system during boot.
(usb start and stop is typically used while booting from usb memory stick)But, stopping the usb stack twice is useless anyway, and a flag already existed that kept track on the usb_init()/usb_stop() calls. So, we now check if the usb stack is really started before we stop it.
Quoted 7 lines
This problem is now fixed in both the upper as low-level layer.
Signed-off-by Remy Bohmer <[email protected]>--- common/usb.c | 13 +++++++++---- drivers/usb/usb_ohci.c | 4 +++- 2 files changed, 12 insertions(+), 5 deletions(-)
Aplied, thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The Gates in my computer are AND, OR and NOT; they are not Bill.