Skip to contentSkip to conversation

CFI: Fix AMD Legacy sector protect

PATCH New Tsi-Chung Liew 2 participants 2 messages Aug 19, 2008 – Aug 20, 2008 Memory technology devices (MTD)

lore
Share & tools
lore

Tsi-Chung Liew

author
#0 lore raw

PATCH 1/1 CFI: Fix AMD Legacy sector protect

From: TsiChung Liew <[email protected]>

New implement sector lock and unlock or softlock commands do not exist in AMD legacy flash. Thus, causing issue when erasing AMD legacy flash (such as lv040)

Signed-off-by TsiChung Liew <[email protected]>
---
 drivers/mtd/cfi_flash.c |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)
drivers/mtd/cfi_flash.c +9 -3
index 58295fe..a412938 100644
@@ -1369,9 +1369,6 @@ int flash_real_protect (flash_info_t * info, long sector, int prot)
 			break;
 		case CFI_CMDSET_AMD_EXTENDED:
 		case CFI_CMDSET_AMD_STANDARD:
-#ifdef CONFIG_FLASH_CFI_LEGACY
-		case CFI_CMDSET_AMD_LEGACY:
-#endif
 			/* U-Boot only checks the first byte */
 			if (info->manufacturer_id == (uchar)ATM_MANUFACT) {
 				if (prot) {

@@ -1392,6 +1389,15 @@ int flash_real_protect (flash_info_t * info, long sector, int prot)
 				}
 			}
 			break;
+#ifdef CONFIG_FLASH_CFI_LEGACY
+		case CFI_CMDSET_AMD_LEGACY:
+			flash_write_cmd (info, sector, 0, FLASH_CMD_CLEAR_STATUS);
+			flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
+			if (prot)
+				flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_SET);
+			else
+				flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_CLEAR);
+#endif
 	};
 
 	if ((retcode =
Signature · 1 line
1.5.6.3
#1 lore raw

PATCH 1/1 CFI: Fix AMD Legacy sector protect

Quoted 5 lines · Tsi-Chung Liew

From: TsiChung Liew <[email protected]>

New implement sector lock and unlock or softlock commands do not exist in AMD legacy flash. Thus, causing issue when erasing AMD legacy flash (such as lv040)

Applied to u-boot-cfi-flash. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================