Skip to contentSkip to conversation

pid_ns: de_thread: kill the now unneeded ->child_reaper change

PATCH In review Oleg Nesterov 4 participants 4 messages Aug 24, 2008 – Aug 27, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 3/4 pid_ns: de_thread: kill the now unneeded ->child_reaper change

de_thread() checks if the old leader was the ->child_reaper, this is not possible any longer. With the previous patch ->group_leader itself will change ->child_reaper on exit.

Quoted 1 line

From now find_new_reaper() is the only function (apart from initialization)

which plays with ->child_reaper.

fs/exec.c renamed from fs/exec.c~3_EXEC +0 -2
@@ -825,8 +825,6 @@ static int de_thread(struct task_struct 
 			schedule();
 		}
 
-		if (unlikely(task_child_reaper(tsk) == leader))
-			task_active_pid_ns(tsk)->child_reaper = tsk;
 		/*
 		 * The only record we have of the real-time age of a
 		 * process, regardless of execs it's done, is start_time.
Acked-by on v1 3/4
#1 lore raw
Quoted 3 lines · Oleg Nesterov

de_thread() checks if the old leader was the ->child_reaper, this is not possible any longer. With the previous patch ->group_leader itself will change ->child_reaper on exit.

Neat.

Quoted 4 lines
Quoted 1 line

From now find_new_reaper() is the only function (apart from initialization)

which plays with ->child_reaper.

Quoted 12 lines
fs/exec.c renamed from fs/exec.c~3_EXEC +0 -2
@@ -825,8 +825,6 @@ static int de_thread(struct task_struct 
 			schedule();
 		}
 
-		if (unlikely(task_child_reaper(tsk) == leader))
-			task_active_pid_ns(tsk)->child_reaper = tsk;
 		/*
 		 * The only record we have of the real-time age of a
 		 * process, regardless of execs it's done, is start_time.
Acked-by on v1 3/4
#2 lore raw
In reply to Oleg Nesterov
Quoted 8 lines · Oleg Nesterov

de_thread() checks if the old leader was the ->child_reaper, this is not possible any longer. With the previous patch ->group_leader itself will change ->child_reaper on exit.

Quoted 1 line

From now find_new_reaper() is the only function (apart from initialization)

which plays with ->child_reaper.

Acked-by Sukadev Bhattiprolu on v1 3/4
#3 lore raw
In reply to Oleg Nesterov

Oleg Nesterov [[email protected]] wrote:

| de_thread() checks if the old leader was the ->child_reaper, this is not
| possible any longer. With the previous patch ->group_leader itself will
| change ->child_reaper on exit.
| 
| >From now find_new_reaper() is the only function (apart from initialization)
| which plays with ->child_reaper.
| 
| Signed-off-by: Oleg Nesterov <[email protected]>