Skip to contentSkip to conversation

devcgroup: remove unused variable

PATCH In review Li Zefan 3 participants 3 messages Aug 25, 2008 1 message not in the archive Security (LSM)

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 devcgroup: remove unused variable

Signed-off-by Li Zefan <[email protected]>
---
 security/device_cgroup.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
security/device_cgroup.c +1 -2
index 9c625f6..d5c15a7 100644
@@ -355,7 +355,7 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
 	struct dev_cgroup *cur_devcgroup;
 	const char *b;
 	char *endp;
-	int retval = 0, count;
+	int count;
 	struct dev_whitelist_item wh;
 
 	if (!capable(CAP_SYS_ADMIN))

@@ -432,7 +432,6 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
 	}
 
 handle:
-	retval = 0;
 	switch (filetype) {
 	case DEVCG_ALLOW:
 		if (!parent_has_perm(devcgroup, &wh))
Signature · 1 line
1.5.4.rc3

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by
#2 lore raw
Quoted 2 lines · Li Zefan
Signed-off-by Li Zefan <[email protected]>

Yup.

Acked-by Serge Hallyn <serue-r/[email protected]>

thanks,
-serge

Quoted 28 lines
---
 security/device_cgroup.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
security/device_cgroup.c +1 -2
index 9c625f6..d5c15a7 100644
@@ -355,7 +355,7 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
 	struct dev_cgroup *cur_devcgroup;
 	const char *b;
 	char *endp;
-	int retval = 0, count;
+	int count;
 	struct dev_whitelist_item wh;
 
 	if (!capable(CAP_SYS_ADMIN))

@@ -432,7 +432,6 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
 	}
 
 handle:
-	retval = 0;
 	switch (filetype) {
 	case DEVCG_ALLOW:
 		if (!parent_has_perm(devcgroup, &wh))
Signature · 1 line
1.5.4.rc3
Acked-by on v1 1/1
#3 lore raw
In reply to Li Zefan
Quoted 2 lines · Li Zefan
Signed-off-by Li Zefan <[email protected]>

Yup.

Acked-by Serge Hallyn <[email protected]>

thanks,
-serge

Quoted 28 lines
---
 security/device_cgroup.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
security/device_cgroup.c +1 -2
index 9c625f6..d5c15a7 100644
@@ -355,7 +355,7 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
 	struct dev_cgroup *cur_devcgroup;
 	const char *b;
 	char *endp;
-	int retval = 0, count;
+	int count;
 	struct dev_whitelist_item wh;
 
 	if (!capable(CAP_SYS_ADMIN))

@@ -432,7 +432,6 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
 	}
 
 handle:
-	retval = 0;
 	switch (filetype) {
 	case DEVCG_ALLOW:
 		if (!parent_has_perm(devcgroup, &wh))
Signature · 1 line
1.5.4.rc3