Skip to contentSkip to conversation

sh: Improved kexec support for SuperH

PATCH In review Magnus Damm 3 participants 13 messages Aug 26, 2008 – Aug 27, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover sh: Improved kexec support for SuperH

Here comes a few SuperH related patches. Trivial stuff - fixing up plain kexec support. Kdump is not ready yet. I also have have a few kdump changes in my local tree but they need more work.

[PATCH 01/06] sh: Add support for sh4al-dsp processors [PATCH 02/06] sh: Get system memory ranges from /proc/iomem [PATCH 03/06] sh: Add virtual addresses support [PATCH 04/06] sh: Autodetect zImage zero page address [PATCH 05/06] sh: Use dynamic zImage load address [PATCH 06/06] sh: Add vmlinux support

Tested with 2.6.27-rc on SuperH Mobile processor models sh7722/sh7723.

---

 kexec/arch/sh/Makefile          |    5 +
 kexec/arch/sh/kexec-elf-sh.c    |  114 +++++++++++++++++++++++++++++++++++++++
 kexec/arch/sh/kexec-sh.c        |   97 ++++++++++++++++++++++-----------
 kexec/arch/sh/kexec-sh.h        |    8 ++
 kexec/arch/sh/kexec-zImage-sh.c |   96 +++++++++++++++++++++++---------
 5 files changed, 260 insertions(+), 60 deletions(-)

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#1 lore raw

PATCH 1/6 sh: Add support for sh4al-dsp processors

From: Magnus Damm <[email protected]>

Add support for sh4al-dsp processors such as sh7722.

---

 kexec/arch/sh/kexec-sh.c |    1 +
 1 file changed, 1 insertion(+)
kexec/arch/sh/kexec-sh.c +1 -0
@@ -105,6 +105,7 @@ const struct arch_map_entry arches[] = {
 	{ "sh3", KEXEC_ARCH_DEFAULT },
 	{ "sh4", KEXEC_ARCH_DEFAULT },
 	{ "sh4a", KEXEC_ARCH_DEFAULT },
+	{ "sh4al-dsp", KEXEC_ARCH_DEFAULT },
 	{ 0 },
 };
 

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#2 lore raw

PATCH 2/6 sh: Get system memory ranges from /proc/iomem

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Parse contents of /proc/iomem instead of hardcoding RAM ranges.

---

 kexec/arch/sh/kexec-sh.c |   26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)
kexec/arch/sh/kexec-sh.c +19 -7
@@ -22,19 +22,31 @@
 #define MAX_MEMORY_RANGES 64
 static struct memory_range memory_range[MAX_MEMORY_RANGES];
 
+static int kexec_sh_memory_range_callback(void *data, int nr,
+					  char *str,
+					  unsigned long base,
+					  unsigned long length)
+{
+	if (nr < MAX_MEMORY_RANGES) {
+		memory_range[nr].start = base;
+		memory_range[nr].end = base + length - 1;
+		memory_range[nr].type = RANGE_RAM;
+		return 0;
+	}
+
+	return 1;
+}
+
 /* Return a sorted list of available memory ranges. */
 int get_memory_ranges(struct memory_range **range, int *ranges,
 		      unsigned long kexec_flags)
 {
-	int memory_ranges;
+	int nr;
 
-	memory_ranges = 0;
-	memory_range[memory_ranges].start = 0x08000000;
-	memory_range[memory_ranges].end   = 0x10000000;
-	memory_range[memory_ranges].type  = RANGE_RAM;
-	memory_ranges++;
+	nr = kexec_iomem_for_each_line("System RAM\n",
+				       kexec_sh_memory_range_callback, NULL);
 	*range = memory_range;
-	*ranges = memory_ranges;
+	*ranges = nr;
 	return 0;
 }
 

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#3 lore raw

PATCH 3/6 sh: Add virtual addresses support

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Implement virtual-to-physical address conversion functions for SuperH.

---

 kexec/arch/sh/Makefile          |    4 ++++
 kexec/arch/sh/kexec-sh.c        |   29 +++++++++++++++++++++++++++++
 kexec/arch/sh/kexec-zImage-sh.c |    4 ++--
 3 files changed, 35 insertions(+), 2 deletions(-)
kexec/arch/sh/Makefile +4 -0
@@ -7,6 +7,10 @@ sh_KEXEC_SRCS += kexec/arch/sh/kexec-net
 sh_KEXEC_SRCS += kexec/arch/sh/kexec-elf-rel-sh.c
 sh_KEXEC_SRCS += kexec/arch/sh/netbsd_booter.S
 
+sh_ADD_BUFFER =
+sh_ADD_SEGMENT =
+sh_VIRT_TO_PHYS =
+
 dist += kexec/arch/sh/Makefile $(sh_KEXEC_SRCS)				\
 	kexec/arch/sh/kexec-sh.h					\
 	kexec/arch/sh/include/arch/options.h
kexec/arch/sh/kexec-sh.c +29 -0
@@ -168,3 +168,32 @@ int is_crashkernel_mem_reserved(void)
 	return 0; /* kdump is not supported on this platform (yet) */
 }
 
+unsigned long virt_to_phys(unsigned long addr)
+{
+	unsigned long seg = addr & 0xe0000000;
+	if (seg != 0x80000000 && seg != 0xc0000000)
+		die("Virtual address %p is not in P1 or P2\n", (void *)addr);
+
+	return addr - seg;
+}
+
+/*
+ * add_segment() should convert base to a physical address on superh,
+ * while the default is just to work with base as is */
+void add_segment(struct kexec_info *info, const void *buf, size_t bufsz,
+		 unsigned long base, size_t memsz)
+{
+	add_segment_phys_virt(info, buf, bufsz, base, memsz, 1);
+}
+
+/*
+ * add_buffer() should convert base to a physical address on superh,
+ * while the default is just to work with base as is */
+unsigned long add_buffer(struct kexec_info *info, const void *buf,
+			 unsigned long bufsz, unsigned long memsz,
+			 unsigned long buf_align, unsigned long buf_min,
+			 unsigned long buf_max, int buf_end)
+{
+	return add_buffer_phys_virt(info, buf, bufsz, memsz, buf_align,
+				    buf_min, buf_max, buf_end, 1);
+}
kexec/arch/sh/kexec-zImage-sh.c +2 -2
@@ -96,8 +96,8 @@ int zImage_sh_load(int argc, char **argv
         paraml = (unsigned long *)param;
 	// paraml[0] = 1;  // readonly flag is set as default
 
-	add_segment(info, param, 4096, empty_zero, 4096);
-	add_segment(info, buf,   len,  (area | 0x00210000), len);
+	add_segment(info, param, 4096, 0x80000000 | empty_zero, 4096);
+	add_segment(info, buf,   len,  (area | 0x80210000), len);
 
 	/* For now we don't have arguments to pass :( */
 	info->entry = (void *)(0x80210000 | area);

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#4 lore raw

PATCH 4/6 sh: Autodetect zImage zero page address

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Autodetect the zero page base address for zImages on SuperH.

---

 kexec/arch/sh/kexec-sh.c        |   40 +++++++------------
 kexec/arch/sh/kexec-sh.h        |    3 -
 kexec/arch/sh/kexec-zImage-sh.c |   79 ++++++++++++++++++++++++++++-----------
 3 files changed, 75 insertions(+), 47 deletions(-)
kexec/arch/sh/kexec-sh.c +16 -24
@@ -65,16 +65,8 @@ void arch_usage(void)
     " none\n\n"
     "Default options:\n"
     " --append=\"%s\"\n"
-    " --empty-zero=0x%08x\n\n"
     " STRING of --appned is set form /proc/cmdline as default.\n"
-    " ADDRESS of --empty-zero can be set SHELL environment variable\n"
-    " KEXEC_EMPTY_ZERO as default.\n\n"
-    " ADDRESS can be get in the following method in your system. \n"
-    " 1) \"grep empty_zero /proc/kallsyms\". \n"
-    " 2) \"grep empty_zero System.map\". \n"
-    " 3) CONFIG_MEMORY_START + CONFIG_ZERO_PAGE_OFFSET in your kernel\n"
-    "    config file.\n"
-    ,get_append(), (unsigned int) get_empty_zero(NULL));
+    ,get_append());
 
 }
 
@@ -130,21 +122,6 @@ void arch_update_purgatory(struct kexec_
 {
 }
 
-
-unsigned long get_empty_zero(char *s)
-{
-        char *env;
-
-	env = getenv("KEXEC_EMPTY_ZERO");
-
-	if(s){
-	  env = s;
-	}else if(!env){
-	  env = "0x0c001000";
-	}
-	return 0x1fffffff & strtoul(env,(char **)NULL,0);
-}
-
 char append_buf[256];
 
 char *get_append(void)
@@ -162,6 +139,21 @@ char *get_append(void)
         return append_buf;
 }
 
+void kexec_sh_setup_zero_page(char *zero_page_buf, int zero_page_size,
+			      char *cmd_line)
+{
+	int n = zero_page_size - 0x100;
+
+	memset(zero_page_buf, 0, zero_page_size);
+	
+	if (cmd_line) {
+		if (n > strlen(cmd_line))
+			n = strlen(cmd_line);
+
+		memcpy(zero_page_buf + 0x100, cmd_line, n);
+		zero_page_buf[0x100 + n] = '\0';
+	}
+}
 
 int is_crashkernel_mem_reserved(void)
 {
kexec/arch/sh/kexec-sh.h +2 -1
@@ -12,6 +12,7 @@ int netbsd_sh_load(int argc, char **argv
 void netbsd_sh_usage(void);
 
 char *get_append(void);
-unsigned long get_empty_zero(char *s);
+void kexec_sh_setup_zero_page(char *zero_page_buf, int zero_page_size,
+			      char *cmd_line);
 
 #endif /* KEXEC_SH_H */
kexec/arch/sh/kexec-zImage-sh.c +57 -22

115 lines not on this page · raw message

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#5 lore raw

PATCH 5/6 sh: Use dynamic zImage load address

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Dynamically calculate SuperH zImage load address instead of hardcoding.

---

 kexec/arch/sh/kexec-zImage-sh.c |   13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
kexec/arch/sh/kexec-zImage-sh.c +9 -4
@@ -79,7 +79,8 @@ int zImage_sh_load(int argc, char **argv
 {
         char *command_line;
 	int opt, k;
-	unsigned long empty_zero, area, zero_page_base, zero_page_size;
+	unsigned long empty_zero, zero_page_base, zero_page_size;
+	unsigned long image_base;
 	char *param;
 
 	static const struct option options[] = {
@@ -137,8 +138,12 @@ int zImage_sh_load(int argc, char **argv
 	add_segment(info, param, zero_page_size,
 		    0x80000000 | zero_page_base, zero_page_size);
 
-	area = empty_zero & 0x1c000000;
-	add_segment(info, buf,   len,  (area | 0x80210000), len);
-	info->entry = (void *)(0x80210000 | area);
+	/* load image a bit above the zero page, round up to 64k
+	 * the zImage will relocate itself, but only up seems supported.
+	 */
+
+	image_base = (empty_zero + (0x10000 - 1)) & ~(0x10000 - 1);
+	add_segment(info, buf, len, image_base, len);
+	info->entry = (void *)image_base;
 	return 0;
 }

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#6 lore raw

PATCH 6/6 sh: Add vmlinux support

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add SuperH vmlinux support through a zero-page aware elf loader. Only for kexec at this point, in the future kdump support will be added.

---

 kexec/arch/sh/Makefile       |    1 
 kexec/arch/sh/kexec-elf-sh.c |  114 ++++++++++++++++++++++++++++++++++++++++++
 kexec/arch/sh/kexec-sh.c     |    1 
 kexec/arch/sh/kexec-sh.h     |    5 +
 4 files changed, 121 insertions(+)
kexec/arch/sh/Makefile +1 -0
@@ -4,6 +4,7 @@
 sh_KEXEC_SRCS += kexec/arch/sh/kexec-sh.c
 sh_KEXEC_SRCS += kexec/arch/sh/kexec-zImage-sh.c
 sh_KEXEC_SRCS += kexec/arch/sh/kexec-netbsd-sh.c
+sh_KEXEC_SRCS += kexec/arch/sh/kexec-elf-sh.c
 sh_KEXEC_SRCS += kexec/arch/sh/kexec-elf-rel-sh.c
 sh_KEXEC_SRCS += kexec/arch/sh/netbsd_booter.S
 
kexec/arch/sh/kexec-elf-sh.c new file +114 -0

114 lines not on this page · raw message

kexec/arch/sh/kexec-sh.c +1 -0
@@ -53,6 +53,7 @@ int get_memory_ranges(struct memory_rang
 /* Supported file types and callbacks */
 struct file_type file_type[] = {
        {"zImage-sh", zImage_sh_probe, zImage_sh_load, zImage_sh_usage},
+       {"elf-sh", elf_sh_probe, elf_sh_load, elf_sh_usage},
        {"netbsd-sh", netbsd_sh_probe, netbsd_sh_load, netbsd_sh_usage},
 };
 int file_types = sizeof(file_type) / sizeof(file_type[0]);
kexec/arch/sh/kexec-sh.h +5 -0
@@ -6,6 +6,11 @@ int zImage_sh_load(int argc, char **argv
 	struct kexec_info *info);
 void zImage_sh_usage(void);
 
+int elf_sh_probe(const char *buf, off_t len);
+int elf_sh_load(int argc, char **argv, const char *buf, off_t len,
+	struct kexec_info *info);
+void elf_sh_usage(void);
+
 int netbsd_sh_probe(const char *buf, off_t len);
 int netbsd_sh_load(int argc, char **argv, const char *buf, off_t len,
 	struct kexec_info *info);

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#7 lore raw

Re: [PATCH 06/06] sh: Add vmlinux support

Quoted 4 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Add SuperH vmlinux support through a zero-page aware elf loader. Only for kexec at this point, in the future kdump support will be added.

Hi Magnus,

If these series of patches are fine by you then they are fine by me. I just have a few minor issues with this last patch.

Quoted 81 lines

---

 kexec/arch/sh/Makefile       |    1 
 kexec/arch/sh/kexec-elf-sh.c |  114 ++++++++++++++++++++++++++++++++++++++++++
 kexec/arch/sh/kexec-sh.c     |    1 
 kexec/arch/sh/kexec-sh.h     |    5 +
 4 files changed, 121 insertions(+)
kexec/arch/sh/Makefile +1 -0
@@ -4,6 +4,7 @@
 sh_KEXEC_SRCS += kexec/arch/sh/kexec-sh.c
 sh_KEXEC_SRCS += kexec/arch/sh/kexec-zImage-sh.c
 sh_KEXEC_SRCS += kexec/arch/sh/kexec-netbsd-sh.c
+sh_KEXEC_SRCS += kexec/arch/sh/kexec-elf-sh.c
 sh_KEXEC_SRCS += kexec/arch/sh/kexec-elf-rel-sh.c
 sh_KEXEC_SRCS += kexec/arch/sh/netbsd_booter.S
 
kexec/arch/sh/kexec-elf-sh.c new file +58 -0
@@ -0,0 +1,114 @@
+/*
+ * kexec: Linux boots Linux
+ *
+ * Copyright (C) 2008  Magnus Damm
+ *
+ * Based on x86 implementation,
+ * Copyright (C) 2003-2005  Eric Biederman ([email protected])
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation (version 2 of the License).
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#define _GNU_SOURCE
+#include <stdio.h>
+#include <string.h>
+#include <stdlib.h>
+#include <errno.h>
+#include <limits.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <getopt.h>
+#include <elf.h>
+#include "../../kexec.h"
+#include "../../kexec-syscall.h"
+#include "../../kexec-elf.h"
+#include "../../kexec-elf-boot.h"
+#include <arch/options.h>
+#include "kexec-sh.h"
+
+int elf_sh_probe(const char *buf, off_t len)
+{
+	struct mem_ehdr ehdr;
+	int result;
+	result = build_elf_exec_info(buf, len, &ehdr, 0);
+	if (result < 0)
+		goto out;
+
+	/* Verify the architecuture specific bits */
+	if (ehdr.e_machine != EM_SH) {
+		result = -1;
+		goto out;
+	}
+
+	result = 0;
+ out:
+	free_elf_info(&ehdr);

kexec/arch/sh/kexec-elf-sh.c line 68

Quoted 10 lines
kexec/arch/sh/kexec-elf-sh.c new file +10 -0
+	return result;
+}
+
+void elf_sh_usage(void)
+{
+	printf("  --append=STRING       Set the kernel command line to STRING\n"
+		);
+}
+
+int elf_sh_load(int argc, char **argv, const char *buf, off_t len, 

The line above has trailing whitespace.

kexec/arch/sh/kexec-elf-sh.c line 77

Quoted 9 lines
kexec/arch/sh/kexec-elf-sh.c new file +9 -0
+	struct kexec_info *info)
+{
+	struct mem_ehdr ehdr;
+	const char *command_line;
+	struct mem_sym sym;
+	int opt;
+	static const struct option options[] = {
+		KEXEC_ARCH_OPTIONS
+		{ 0, 			0, NULL, 0 },

The line above has a stray space after 0 (and before a tab).

Quoted 23 lines
kexec/arch/sh/kexec-elf-sh.c new file +23 -0
+	};
+
+	static const char short_options[] = KEXEC_OPT_STR "";
+
+	/*
+	 * Parse the command line arguments
+	 */
+	command_line = 0;
+	while((opt = getopt_long(argc, argv, short_options, options, 0)) != -1) {
+		switch(opt) {
+		default:
+			/* Ignore core options */
+			if (opt < OPT_ARCH_MAX) {
+				break;
+			}
+		case '?':
+			usage();
+			return -1;
+		case OPT_APPEND:
+			command_line = optarg;
+			break;
+		}
+	}

kexec/arch/sh/kexec-elf-sh.c line 110

Quoted 10 lines
kexec/arch/sh/kexec-elf-sh.c new file +10 -0
+
+	/* Load the ELF executable */
+	elf_exec_build_load(info, &ehdr, buf, len, 0);
+	info->entry = (void *)ehdr.e_entry;
+
+	/* If we're booting a vmlinux then fill in empty_zero_page */
+	if (elf_rel_find_symbol(&ehdr, "empty_zero_page", &sym) == 0) {
+		unsigned char *zp = (void *)ehdr.e_shdr[sym.st_shndx].sh_data;
+
+		kexec_sh_setup_zero_page(zp, 4096, command_line);

kexec_sh_setup_zero_page() seems to want a signed char * as the first argument. Does it make sense to just change zp accordingly?

Quoted 18 lines
kexec/arch/sh/kexec-elf-sh.c new file +4 -0
+	}
+
+	return 0;
+}
kexec/arch/sh/kexec-sh.c +1 -0
@@ -53,6 +53,7 @@ int get_memory_ranges(struct memory_rang
 /* Supported file types and callbacks */
 struct file_type file_type[] = {
        {"zImage-sh", zImage_sh_probe, zImage_sh_load, zImage_sh_usage},
+       {"elf-sh", elf_sh_probe, elf_sh_load, elf_sh_usage},
        {"netbsd-sh", netbsd_sh_probe, netbsd_sh_load, netbsd_sh_usage},
 };
 int file_types = sizeof(file_type) / sizeof(file_type[0]);
kexec/arch/sh/kexec-sh.h +0 -0
@@ -6,6 +6,11 @@ int zImage_sh_load(int argc, char **argv
 	struct kexec_info *info);

kexec/arch/sh/kexec-sh.h int zImage_sh_load(int argc, char **argv · line 16

Quoted 10 lines
kexec/arch/sh/kexec-sh.h +5 -0
 void zImage_sh_usage(void);
 
+int elf_sh_probe(const char *buf, off_t len);
+int elf_sh_load(int argc, char **argv, const char *buf, off_t len,
+	struct kexec_info *info);
+void elf_sh_usage(void);
+
 int netbsd_sh_probe(const char *buf, off_t len);
 int netbsd_sh_load(int argc, char **argv, const char *buf, off_t len,
 	struct kexec_info *info);

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#8 lore raw

Re: [PATCH 06/06] sh: Add vmlinux support

Hi Simon,

Quoted 8 lines · Simon Horman
Quoted 4 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Add SuperH vmlinux support through a zero-page aware elf loader. Only for kexec at this point, in the future kdump support will be added.

If these series of patches are fine by you then they are fine by me. I just have a few minor issues with this last patch.

How does the attached patch look?

Thanks for your help!

/ magnus

kexec/arch/sh/kexec-elf-sh.c +5 -5
@@ -65,16 +65,16 @@ void elf_sh_usage(void)
 		);
 }
 
-int elf_sh_load(int argc, char **argv, const char *buf, off_t len, 
-	struct kexec_info *info)
+int elf_sh_load(int argc, char **argv, const char *buf, off_t len,
+		struct kexec_info *info)
 {
 	struct mem_ehdr ehdr;
-	const char *command_line;
+	char *command_line;
 	struct mem_sym sym;
 	int opt;
 	static const struct option options[] = {
 		KEXEC_ARCH_OPTIONS
-		{ 0, 			0, NULL, 0 },
+		{ 0, 0, 0, 0 },
 	};
 
 	static const char short_options[] = KEXEC_OPT_STR "";
@@ -105,7 +105,7 @@ int elf_sh_load(int argc, char **argv, c
 
 	/* If we're booting a vmlinux then fill in empty_zero_page */
 	if (elf_rel_find_symbol(&ehdr, "empty_zero_page", &sym) == 0) {
-		unsigned char *zp = (void *)ehdr.e_shdr[sym.st_shndx].sh_data;
+		char *zp = (void *)ehdr.e_shdr[sym.st_shndx].sh_data;
 
 		kexec_sh_setup_zero_page(zp, 4096, command_line);
 	}

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#9 lore raw

Re: [PATCH 06/06] sh: Add vmlinux support

Quoted 9 lines · Magnus Damm

Hi Simon,

Quoted 6 lines · Simon Horman
Quoted 4 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Add SuperH vmlinux support through a zero-page aware elf loader. Only for kexec at this point, in the future kdump support will be added.

Quoted 6 lines
Quoted 2 lines

If these series of patches are fine by you then they are fine by me. I just have a few minor issues with this last patch.

How does the attached patch look?

Thanks for your help!

Much better :-)

Should I just fold it into the last patch and push ?

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#10 lore raw

Re: [PATCH 06/06] sh: Add vmlinux support

Quoted 13 lines · Simon Horman
Quoted 12 lines · Magnus Damm

Hi Simon,

Quoted 8 lines · Simon Horman
Quoted 4 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Add SuperH vmlinux support through a zero-page aware elf loader. Only for kexec at this point, in the future kdump support will be added.

If these series of patches are fine by you then they are fine by me. I just have a few minor issues with this last patch.

Quoted 7 lines
Quoted 3 lines

How does the attached patch look?

Thanks for your help!

Much better :-)

Should I just fold it into the last patch and push ?

Yes, that would be great! Thanks! =)

/ magnus

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#11 lore raw

Re: [PATCH 06/06] sh: Add vmlinux support

Quoted 16 lines · Magnus Damm
Quoted 15 lines · Simon Horman
Quoted 14 lines · Magnus Damm

Hi Simon,

Quoted 8 lines · Simon Horman
Quoted 4 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Add SuperH vmlinux support through a zero-page aware elf loader. Only for kexec at this point, in the future kdump support will be added.

If these series of patches are fine by you then they are fine by me. I just have a few minor issues with this last patch.

How does the attached patch look?

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Thanks for your help!

Much better :-)

Should I just fold it into the last patch and push ?

Yes, that would be great! Thanks! =)

Great. I've pushed the patches and included Paul's ack.

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Acked-by on the v1 series
#12 lore raw
In reply to Magnus Damm
Quoted 11 lines · Magnus Damm

Here comes a few SuperH related patches. Trivial stuff - fixing up plain kexec support. Kdump is not ready yet. I also have have a few kdump changes in my local tree but they need more work.

[PATCH 01/06] sh: Add support for sh4al-dsp processors [PATCH 02/06] sh: Get system memory ranges from /proc/iomem [PATCH 03/06] sh: Add virtual addresses support [PATCH 04/06] sh: Autodetect zImage zero page address [PATCH 05/06] sh: Use dynamic zImage load address [PATCH 06/06] sh: Add vmlinux support

Quoted 3 lines

Tested with 2.6.27-rc on SuperH Mobile processor models sh7722/sh7723.

FWIW:

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec