ASoC: Convert wm8750 to a new-style i2c driver (testers wanted)

Convert the wm8750 codec driver to the new (standard) device driver binding model.

---
Warning: this assumes that the spitz has its codec chip on I2C bus 0, which may or may not be the case. Someone with this machine please test and report.

Note that you can safely ignore patch failures in i2c-id.h.

 include/linux/i2c-id.h    |    1 
 sound/soc/codecs/wm8750.c |  108 ++++++++++++++++++++++-----------------------
 sound/soc/codecs/wm8750.h |    1 
 sound/soc/pxa/spitz.c     |    1 
 4 files changed, 57 insertions(+), 54 deletions(-)

@@ -65,7 +65,6 @@
 #define I2C_DRIVERID_DS1672	81	/* Dallas/Maxim DS1672 RTC	*/
 #define I2C_DRIVERID_TLV320AIC23B 87	/* TI TLV320AIC23B audio codec  */
 #define I2C_DRIVERID_WM8731	89	/* Wolfson WM8731 audio codec */
-#define I2C_DRIVERID_WM8750	90	/* Wolfson WM8750 audio codec */
 #define I2C_DRIVERID_WM8753	91	/* Wolfson WM8753 audio codec */
 #define I2C_DRIVERID_LM4857 	92 	/* LM4857 Audio Amplifier */
 #define I2C_DRIVERID_VP27SMPX	93	/* Panasonic VP27s tuner internal MPX */

@@ -58,6 +58,7 @@
 #define WM8750_SYSCLK	0
 
 struct wm8750_setup_data {
+	int i2c_bus;
 	unsigned short i2c_address;
 };
 

@@ -337,6 +337,7 @@ static struct snd_soc_machine snd_soc_ma
 
 /* spitz audio private data */
 static struct wm8750_setup_data spitz_wm8750_setup = {
+	.i2c_bus = 0,
 	.i2c_address = 0x1b,
 };
 

Jean Delvare

for the wm8750 driver. I'm pretty confident the spitz change is correct too but don't have hardware to actually test.

I agree. Usually I am the first one to yell at people who explicitly initialize struct members to 0, but in this specific case I think it is a good idea to make sure that other developers notice the change.

Jean Delvare