Skip to contentSkip to conversation

may be a bug?

DISCUSSION Payphone LIOU 2 participants 2 messages Aug 28, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi, ALL.

in moutd.h of nfs-utils-1.1.3, an union object was defined below.

union mountd_results {
	fhstatus		fstatus;
	mountlist		mountlist;
	exports			exports;
};

the space size of mountd_results is the maximum one among fsstaus,mountlist and exports, and all of them are the output arguments of mountd procedures. in nfsv3, mount_mnt_3_svc takes "mountres3" as its output. so i think it may be :

union mountd_results {
	fhstatus		fstatus;
	mountlist		mountlist;
	exports			exports;
	mountres3    mountres3;
};

because the size of fstatus is larger than mountres3, no erros happens. but i think semantically "mountres3" should be added into this union structure. am i wrong?

thansk a lot.

Best regards. :-)

Payphone LIOU

#1 lore raw
Quoted 19 lines · Payphone LIOU

Hi, ALL.

in moutd.h of nfs-utils-1.1.3, an union object was defined below.

union mountd_results {
	fhstatus		fstatus;
	mountlist		mountlist;
	exports			exports;
};

the space size of mountd_results is the maximum one among fsstaus,mountlist and exports, and all of them are the output arguments of mountd procedures. in nfsv3, mount_mnt_3_svc takes "mountres3" as its output. so i think it may be :

union mountd_results {
	fhstatus		fstatus;
	mountlist		mountlist;
	exports			exports;
	mountres3    mountres3;
};
Quoted 3 lines

because the size of fstatus is larger than mountres3, no erros happens. but i think semantically "mountres3" should be added into this union structure. am i wrong?

From a quick glance..... Yes, I agree, that looks suspicious. Perhaps

you could send a patch? (Address it to [email protected], cc'd to this list.)

--b.

Quoted 11 lines

thansk a lot.

Best regards. :-)

Payphone LIOU

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html