Skip to contentSkip to conversation

make might_sleep() display the oopsing process

PATCH In review Joe Korty 4 participants 5 messages Aug 27, 2008 – Aug 30, 2008

lore
Share & tools
lore

Joe Korty

author
#0 lore raw

PATCH 1/1 make might_sleep() display the oopsing process

Expand might_sleep's printk to indicate the oopsing process.

kernel/sched.c +2 -2
Index: 2.6.27-rc4-git4/kernel/sched.c
===================================================================
@@ -8183,8 +8183,8 @@
 		prev_jiffy = jiffies;
 		printk(KERN_ERR "BUG: sleeping function called from invalid"
 				" context at %s:%d\n", file, line);
-		printk("in_atomic():%d, irqs_disabled():%d\n",
-			in_atomic(), irqs_disabled());
+		printk("in_atomic():%d, irqs_disabled():%d, pid: %d, name: %s\n",
+			in_atomic(), irqs_disabled(), current->pid, current->comm);
 		debug_show_held_locks(current);
 		if (irqs_disabled())
 			print_irqtrace_events(current);
#1 lore raw
Quoted 1 line · Joe Korty

Expand might_sleep's printk to indicate the oopsing process.

good idea - applied to tip/sched/devel - thanks Joe.

Ingo

#2 lore raw
Quoted 3 lines · On Thu, 28 Aug 2008 11:36:28 +0200 Ingo Molnar <[email protected]> wrote:
Quoted 1 line

Expand might_sleep's printk to indicate the oopsing process.

good idea

Why? I don't recall ever having been interested in this information.

(I shouldn't have to ask questions like this. Please spend a little more time in preparing the patch descriptions).

author
#3 lore raw
Quoted 11 lines · Andrew Morton
Quoted 3 lines · On Thu, 28 Aug 2008 11:36:28 +0200 Ingo Molnar <[email protected]> wrote:
Quoted 1 line

Expand might_sleep's printk to indicate the oopsing process.

good idea

Why? I don't recall ever having been interested in this information.

(I shouldn't have to ask questions like this. Please spend a little more time in preparing the patch descriptions).

I wrote and used the patch once, as I wanted to know which program in a lengthy multiple-program test suite was triggering the problem. That made it easier coming up with a shortened test that would replicate the problem.

However I only needed it that one time so this patch can be considered to be exceptionally optional :)

Joe

#4 lore raw
Quoted 14 lines · On Sat, 30 Aug 2008 10:45:20 -0400 Joe Korty <[email protected]> wrote:
Quoted 5 lines · Andrew Morton
Quoted 2 lines · On Thu, 28 Aug 2008 11:36:28 +0200 Ingo Molnar <[email protected]> wrote:
Quoted 1 line

Expand might_sleep's printk to indicate the oopsing process.

Quoted 7 lines
Quoted 1 line

good idea

Why? I don't recall ever having been interested in this information.

(I shouldn't have to ask questions like this. Please spend a little more time in preparing the patch descriptions).

Quoted 7 lines

I wrote and used the patch once, as I wanted to know which program in a lengthy multiple-program test suite was triggering the problem. That made it easier coming up with a shortened test that would replicate the problem.

However I only needed it that one time so this patch can be considered to be exceptionally optional :)

WARN() and WARN_ON() already print the oopsing process. so if might_sleep() just calls one of those it already prints it. If it doesn't call one of these.. maybe it should?

Signature · 3 lines
If you want to reach me at my work email, use [email protected]
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org