Skip to contentSkip to conversation

ASoC: Convert wm8753 to a new-style i2c driver

PATCH In review Jean Delvare 2 participants 2 messages Sep 1, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/3 ASoC: Convert wm8753 to a new-style i2c driver

Convert the wm8753 codec driver to the new (standard) i2c device driver binding model.

Cc Ville Syrjala <[email protected]>
Cc Frank Mandarino <[email protected]>
Cc Mark Brown <[email protected]>

---
Warning: this assumes that the neo1973 has its codec chip on I2C bus 0, which may or may not be the case. Someone with this machine please test and report.

 include/linux/i2c-id.h             |    1 
 sound/soc/codecs/wm8753.c          |  106 ++++++++++++++++++------------------
 sound/soc/codecs/wm8753.h          |    1 
 sound/soc/s3c24xx/neo1973_wm8753.c |    1 
 4 files changed, 55 insertions(+), 54 deletions(-)
include/linux/i2c-id.h +0 -1
@@ -64,7 +64,6 @@
 #define I2C_DRIVERID_SAA717X	80	/* saa717x video encoder	*/
 #define I2C_DRIVERID_DS1672	81	/* Dallas/Maxim DS1672 RTC	*/
 #define I2C_DRIVERID_TLV320AIC23B 87	/* TI TLV320AIC23B audio codec  */
-#define I2C_DRIVERID_WM8753	91	/* Wolfson WM8753 audio codec */
 #define I2C_DRIVERID_LM4857 	92 	/* LM4857 Audio Amplifier */
 #define I2C_DRIVERID_VP27SMPX	93	/* Panasonic VP27s tuner internal MPX */
 #define I2C_DRIVERID_CS4270	94	/* Cirrus Logic 4270 audio codec */
sound/soc/codecs/wm8753.c +53 -53

154 lines not on this page · raw message

sound/soc/codecs/wm8753.h +1 -0
@@ -79,6 +79,7 @@
 #define WM8753_ADCTL2		0x3f
 
 struct wm8753_setup_data {
+	int i2c_bus;
 	unsigned short i2c_address;
 };
 
sound/soc/s3c24xx/neo1973_wm8753.c +1 -0
@@ -586,6 +586,7 @@ static struct snd_soc_machine neo1973 = 
 };
 
 static struct wm8753_setup_data neo1973_wm8753_setup = {
+	.i2c_bus = 0,
 	.i2c_address = 0x1a,
 };
 
Signature · 1 line
Jean Delvare
Acked-by on v1 2/3
#1 lore raw
Quoted 7 lines · Jean Delvare

Convert the wm8753 codec driver to the new (standard) i2c device driver binding model.

Cc Ville Syrjala <[email protected]>
Cc Frank Mandarino <[email protected]>
Cc Mark Brown <[email protected]>
Quoted 3 lines

Warning: this assumes that the neo1973 has its codec chip on I2C bus 0, which may or may not be the case. Someone with this machine please test and report.

I can confirm that the codec is on bus zero (but haven't actually tested with this patch on the Neo!).