Skip to contentSkip to conversation

Problem w/ CONFIG_DEBUG_BLOCK_EXT_DEVT

DISCUSSION Alan D. Brunelle 4 participants 7 messages Sep 2, 2008 Device mapper

lore
Share & tools
lore
#0 lore raw

I have found two problems in LVM2/DM w/ a potential new "experimental feature" in 2.6.28: CONFIG_DEBUG_BLOCK_EXT_DEVT (this is from Jens Axboe's origin/for-2.6.28 git branch)

"Conventionally, block device numbers are allocated from predetermined contiguous area. However, extended block area may introduce non-contiguous block device numbers. This option forces most block device numbers to be allocated from the extended space and spreads them to discover kernel or userland code paths which assume predetermined contiguous device number allocation."

W/ LVM2 & DM there are (at least) two issues:

(1) Device major numbers for some reason are /not/ being entered correctly into /proc/devices -- w/ CONFIG_DEBUG_BLOCK_EXT_DEVT=y I am seeing some devices w/ major "259" (a SATA controller) but no entry in /proc/devices. LVM2/DM will not find the entry in /proc/devices, and not allow any device w/ that major to be used with LVM commands.

(2) Device minor numbers can be quite large, and the 10-character limits in dm/lib/libdm-deptree.c are too small.

Alan

#1 lore raw

Hello,

Quoted 3 lines · Alan D. Brunelle

I have found two problems in LVM2/DM w/ a potential new "experimental feature" in 2.6.28: CONFIG_DEBUG_BLOCK_EXT_DEVT (this is from Jens Axboe's origin/for-2.6.28 git branch)

It's a debug option and I don't expect it to be enabled in any production kernel.

Quoted 7 lines

"Conventionally, block device numbers are allocated from predetermined contiguous area. However, extended block area may introduce non-contiguous block device numbers. This option forces most block device numbers to be allocated from the extended space and spreads them to discover kernel or userland code paths which assume predetermined contiguous device number allocation."

Quoted 7 lines

W/ LVM2 & DM there are (at least) two issues:

(1) Device major numbers for some reason are /not/ being entered correctly into /proc/devices -- w/ CONFIG_DEBUG_BLOCK_EXT_DEVT=y I am seeing some devices w/ major "259" (a SATA controller) but no entry in /proc/devices. LVM2/DM will not find the entry in /proc/devices, and not allow any device w/ that major to be used with LVM commands.

Hmmm.. Adding a call to register_blkdev(), which will create the corresponding entry in /proc/devices, isn't difficult at all but which name would it use? It'll be mix of block devices (hd and sds currently). If we introduce a new name there, say, ext-block, would that work? BTW, is there any specific reason why LVM2/DM can't use /sys/block/* ?

Quoted 2 lines

(2) Device minor numbers can be quite large, and the 10-character limits in dm/lib/libdm-deptree.c are too small.

Would it be difficult to increase that?

Thanks.

Signature · 1 line
tejun
#2 lore raw
Quoted 9 lines · Tejun Heo

Hello,

Quoted 3 lines · Alan D. Brunelle

I have found two problems in LVM2/DM w/ a potential new "experimental feature" in 2.6.28: CONFIG_DEBUG_BLOCK_EXT_DEVT (this is from Jens Axboe's origin/for-2.6.28 git branch)

It's a debug option and I don't expect it to be enabled in any production kernel.

Then perhaps it should /not/ default to Y...

Quoted 23 lines
Quoted 8 lines

"Conventionally, block device numbers are allocated from predetermined contiguous area. However, extended block area may introduce non-contiguous block device numbers. This option forces most block device numbers to be allocated from the extended space and spreads them to discover kernel or userland code paths which assume predetermined contiguous device number allocation."

Quoted 7 lines

W/ LVM2 & DM there are (at least) two issues:

(1) Device major numbers for some reason are /not/ being entered correctly into /proc/devices -- w/ CONFIG_DEBUG_BLOCK_EXT_DEVT=y I am seeing some devices w/ major "259" (a SATA controller) but no entry in /proc/devices. LVM2/DM will not find the entry in /proc/devices, and not allow any device w/ that major to be used with LVM commands.

Hmmm.. Adding a call to register_blkdev(), which will create the corresponding entry in /proc/devices, isn't difficult at all but which name would it use? It'll be mix of block devices (hd and sds currently). If we introduce a new name there, say, ext-block, would that work? BTW, is there any specific reason why LVM2/DM can't use /sys/block/* ?

Quoted 4 lines
Quoted 2 lines

(2) Device minor numbers can be quite large, and the 10-character limits in dm/lib/libdm-deptree.c are too small.

Would it be difficult to increase that?

No, but knowing the upper bound would be helpful.

Quoted 3 lines

Thanks.

#3 lore raw
Quoted 4 lines · Alan D. Brunelle
Quoted 3 lines · Tejun Heo

Hello,

Alan D. Brunelle wrote:

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

I have found two problems in LVM2/DM w/ a potential new "experimental feature" in 2.6.28: CONFIG_DEBUG_BLOCK_EXT_DEVT (this is from Jens Axboe's origin/for-2.6.28 git branch)

It's a debug option and I don't expect it to be enabled in any production kernel.

Then perhaps it should /not/ default to Y...

It has already been changed to default to 'n'.

Signature · 1 line
Jens Axboe
#4 lore raw
In reply to Alan D. Brunelle
Quoted 5 lines · Alan D. Brunelle
Quoted 3 lines
Quoted 2 lines

(2) Device minor numbers can be quite large, and the 10-character limits in dm/lib/libdm-deptree.c are too small.

Would it be difficult to increase that?

No, but knowing the upper bound would be helpful.

Well, dev_t is 32bits and MINORBITS is 20. So, major 12 bits, minor 20 bits, so 4 characters for major, 7 characters for minor.

Signature · 1 line
tejun
#5 lore raw
Quoted 2 lines · Tejun Heo

Well, dev_t is 32bits and MINORBITS is 20. So, major 12 bits, minor 20 bits, so 4 characters for major, 7 characters for minor.

Upstream libdevmapper CVS patched - will appear in next release (1.02.28).

Alasdair

Signature · 1 line
[email protected]
#6 lore raw
Quoted 5 lines · Alasdair G Kergon
Quoted 2 lines · Tejun Heo

Well, dev_t is 32bits and MINORBITS is 20. So, major 12 bits, minor 20 bits, so 4 characters for major, 7 characters for minor.

Upstream libdevmapper CVS patched - will appear in next release (1.02.28).

Alright, thanks. What about the /proc/devices one? Would adding an entry help? I'm kind of lost /proc/devices. It's now mostly non-functional legacy stuff we've been carrying around. Is it deprecated or do we intend to keep it around forever?

Ooh.. which also reminds me that I forgot to reserve the major number w/ lanana. Will do that.

Thanks.

Signature · 1 line
tejun