Skip to contentSkip to conversation

ASoC: Convert wm8510 to a new-style i2c driver (v2)

PATCH In review Jean Delvare 2 participants 3 messages Sep 2, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Convert wm8510 to a new-style i2c driver (v2)

Convert the wm8510 codec driver to the new (standard) device driver binding model.

---
As noticed by Mark, my 1st patch didn't apply properly. Here's a fixed version which should apply fine. Sorry for the noise.

Warning: this assumes that the playpaq has its codec chip on I2C bus 0, which may or may not be the case. Someone with this machine please test and report.

 sound/soc/at32/playpaq_wm8510.c |    1 
 sound/soc/codecs/wm8510.c       |  110 ++++++++++++++++++---------------------
 sound/soc/codecs/wm8510.h       |    1 
 3 files changed, 55 insertions(+), 57 deletions(-)
sound/soc/at32/playpaq_wm8510.c +1 -0
@@ -377,6 +377,7 @@ static struct snd_soc_machine snd_soc_ma
 
 
 static struct wm8510_setup_data playpaq_wm8510_setup = {
+	.i2c_bus = 0,
 	.i2c_address = 0x1a,
 };
 
sound/soc/codecs/wm8510.c +53 -57

158 lines not on this page · raw message

sound/soc/codecs/wm8510.h +1 -0
@@ -94,6 +94,7 @@
 #define WM8510_MCLKDIV_12	(7 << 5)
 
 struct wm8510_setup_data {
+	int i2c_bus;
 	unsigned short i2c_address;
 };
 
Signature · 1 line
Jean Delvare
#1 lore raw
Quoted 2 lines · Jean Delvare

Convert the wm8510 codec driver to the new (standard) device driver binding model.

If you ever bump into either Mark or I at a conference then we are probably due you a beer or two for all this fine work.

Cheers

Liam

#2 lore raw
Quoted 6 lines · Liam Girdwood
Quoted 2 lines · Jean Delvare

Convert the wm8510 codec driver to the new (standard) device driver binding model.

If you ever bump into either Mark or I at a conference then we are probably due you a beer or two for all this fine work.

I'll be at the joint reception between the Kernel Summit and the Plumbers Conference in Portland in 2 weeks, if you happen to be there as well. That being said, on my personal scale, the review work you and Mark have done has more value than my contributions, so I owe both of you a beer if anything.

(And that's ginger ale for me, not beer, but that's an implementation details ;))

Signature · 1 line
Jean Delvare