atmel_lcdfb: Disallow to set larger resolution than framebuffer memory can handle
Subsystems (2)
PATCH 2/2 atmel_lcdfb: Disallow to set larger resolution than framebuffer memory can handle
--- drivers/video/atmel_lcdfb.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
drivers/video/atmel_lcdfb.c +7 -0
@@ -342,6 +342,13 @@ static int atmel_lcdfb_check_var(struct fb_var_screeninfo *var, var->transp.offset = var->transp.length =0 ; var->xoffset = var->yoffset =0 ; +if (info->fix.smem_len) { +unsigned int smem_len = (var->xres_virtual * var->yres_virtual + * ((var->bits_per_pixel +7 ) /8 )); +if (smem_len > info->fix.smem_len) +return -EINVAL ; + } +/* Saturate vertical and horizontal timings at maximum values */ var->vsync_len =min_t (u32, var->vsync_len, (ATMEL_LCDC_VPW >>ATMEL_LCDC_VPW_OFFSET ) +1 );
Signature · 8 lines
1.5.2.5 ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
Quoted 11 lines · On Wed, 3 Sep 2008 15:37:40 +0200 Stanislaw Gruszka <[email protected]> wrote:
Signed-off-by Stanislaw Gruszka <[email protected]>CC Nicolas Ferre <[email protected]>--- drivers/video/atmel_lcdfb.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)drivers/video/atmel_lcdfb.c +0
-0
drivers/video/atmel_lcdfb.c static int atmel_lcdfb_check_var(struct fb_var_screeninfo *var, · line 345
Quoted 4 lines
drivers/video/atmel_lcdfb.c +1
-0@@ -342,6 +342,13 @@ static int atmel_lcdfb_check_var(struct fb_var_screeninfo *var, var->transp.offset = var->transp.length =0 ; var->xoffset = var->yoffset =0 ; +if (info->fix.smem_len) {
Is it possible to have smem_len not set in the atmel_lcdfb? Probably not as it is always set in the probe function.
Kind regards,
Krzysztof
Quoted 13 lines
drivers/video/atmel_lcdfb.c +6
-0+unsigned int smem_len = (var->xres_virtual * var->yres_virtual + * ((var->bits_per_pixel +7 ) /8 )); +if (smem_len > info->fix.smem_len) +return -EINVAL ; + } +/* Saturate vertical and horizontal timings at maximum values */ var->vsync_len =min_t (u32, var->vsync_len, (ATMEL_LCDC_VPW >>ATMEL_LCDC_VPW_OFFSET ) +1 );Signature · 1 line
1.5.2.5
----------------------------------------------------------------------
Teraz taniej na zagraniczne komorki!
Sprawdz >> http://link.interia.pl/f1ef7
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
Wednesday 03 September 2008 20:59:26 Krzysztof Helt napisał(a):
Quoted 17 lines
Quoted 14 lines · On Wed, 3 Sep 2008 15:37:40 +0200 Stanislaw Gruszka <[email protected]> wrote:
Signed-off-by Stanislaw Gruszka <[email protected]>CC Nicolas Ferre <[email protected]>--- drivers/video/atmel_lcdfb.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)drivers/video/atmel_lcdfb.c +0
-0@@ -342,6 +342,13 @@ static int atmel_lcdfb_check_var(struct fb_var_screeninfo *var, var->transp.offset = var->transp.length =0 ; var->xoffset = var->yoffset =0 ;
Quoted 4 lines
drivers/video/atmel_lcdfb.c static int atmel_lcdfb_check_var(struct fb_var_screeninfo *var, · line 345
Quoted 1 line
drivers/video/atmel_lcdfb.c +1
-0+if (info->fix.smem_len) {Is it possible to have
smem_lennot set in theatmel_lcdfb? Probably not as it is always set in the probe function.
fb_check_var() is called indirectly (via fb_find_mode() call) before smem_len is setted in probe function. And in some cases we need to know resolution to set up smem_len and allocate memory (egg and chicken problem). So such check is needed in atmel_lcdfb_check_var().
Cheers
Stanislaw Gruszka
Quoted 16 lines
Kind regards,
KrzysztofQuoted 13 lines
drivers/video/atmel_lcdfb.c +6
-0+unsigned int smem_len = (var->xres_virtual * var->yres_virtual + * ((var->bits_per_pixel +7 ) /8 )); +if (smem_len > info->fix.smem_len) +return -EINVAL ; + } +/* Saturate vertical and horizontal timings at maximum values */ var->vsync_len =min_t (u32, var->vsync_len, (ATMEL_LCDC_VPW >>ATMEL_LCDC_VPW_OFFSET ) +1 );Signature · 1 line
1.5.2.5
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Linux-fbdev-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
Stanislaw Gruszka :
Quoted 2 lines
Signed-off-by Stanislaw Gruszka <[email protected]>CC Nicolas Ferre <[email protected]>
Quoted 22 lines
--- drivers/video/atmel_lcdfb.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)drivers/video/atmel_lcdfb.c +7
-0@@ -342,6 +342,13 @@ static int atmel_lcdfb_check_var(struct fb_var_screeninfo *var, var->transp.offset = var->transp.length =0 ; var->xoffset = var->yoffset =0 ; +if (info->fix.smem_len) { +unsigned int smem_len = (var->xres_virtual * var->yres_virtual + * ((var->bits_per_pixel +7 ) /8 )); +if (smem_len > info->fix.smem_len) +return -EINVAL ; + } +/* Saturate vertical and horizontal timings at maximum values */ var->vsync_len =min_t (u32, var->vsync_len, (ATMEL_LCDC_VPW >>ATMEL_LCDC_VPW_OFFSET ) +1 );
Signature · 8 lines
Nicolas Ferre ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/