Skip to contentSkip to conversation

Drop -funroll-loops for csum_partial_64.c

PATCH Applied Andi Kleen 2 participants 2 messages Sep 4, 2008 x86

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 Drop -funroll-loops for csum_partial_64.c

Drop -funroll-loops for csum_partial_64.c

I did some rebenchmarking with modern compilers and dropping -funroll-loops makes the function consistently go faster by a few percent. So drop that flag.

Thanks to Richard Guenther for a hint.

---
 arch/x86/lib/Makefile |    3 ---
 1 file changed, 3 deletions(-)
arch/x86/lib/Makefile +0 -3
Index: linux-2.6.27-rc4-misc/arch/x86/lib/Makefile
===================================================================
@@ -17,9 +17,6 @@ ifeq ($(CONFIG_X86_32),y)
         lib-$(CONFIG_X86_USE_3DNOW) += mmx_32.o
 else
         obj-y += io_64.o iomap_copy_64.o
-
-        CFLAGS_csum-partial_64.o := -funroll-loops
-
         lib-y += csum-partial_64.o csum-copy_64.o csum-wrappers_64.o
         lib-y += thunk_64.o clear_page_64.o copy_page_64.o
         lib-y += memmove_64.o memset_64.o
#1 lore raw
Quoted 1 line · Andi Kleen

Drop -funroll-loops for csum_partial_64.c

Applied to tip:x86/core. Thanks.

-hpa