85xx: Ensure timebase is zero on secondary cores
PATCH 1/1 85xx: Ensure timebase is zero on secondary cores
The e500um says the timebase is volatile out of reset. To ensure TB sync works we need to make sure its zero.
--- cpu/mpc85xx/release.S | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
cpu/mpc85xx/release.S +5 -0
@@ -37,6 +37,11 @@ __secondary_start_page: li r3,0x201 mtspr SPRN_BUCSR,r3 + /* Ensure TB is 0 */ + li r3,0 + mttbu r3 + mttbl r3 + /* Enable/invalidate the I-Cache */ mfspr r0,SPRN_L1CSR1 ori r0,r0,(L1CSR1_ICFI|L1CSR1_ICE)
Signature · 1 line
1.5.5.1
PATCH 1/1 85xx: Ensure timebase is zero on secondary cores
cpu/mpc85xx/release.S __secondary_start_page: · line 43
Quoted 12 lines · Kumar Gala
cpu/mpc85xx/release.S +4
-0@@ -37,6 +37,11 @@ __secondary_start_page: li r3,0x201 mtspr SPRN_BUCSR,r3 + /* Ensure TB is 0 */ + li r3,0 + mttbu r3 + mttbl r3
If it's possible that TBL is a small negative number out of reset, then we should write TBL before TBU to avoid a rollover race.
-Scott
PATCH 1/1 85xx: Ensure timebase is zero on secondary cores
Quoted 9 lines · Scott Wood
Quoted 8 lines · Kumar Gala
cpu/mpc85xx/release.S +0
-0@@ -37,6 +37,11 @@ __secondary_start_page: li r3,0x201 mtspr SPRN_BUCSR,r3
Quoted 8 lines
cpu/mpc85xx/release.S __secondary_start_page: · line 43
Quoted 4 lines
cpu/mpc85xx/release.S +4
-0+ /* Ensure TB is 0 */ + li r3,0 + mttbu r3 + mttbl r3If it's possible that TBL is a small negative number out of reset, then
we should write TBL before TBU to avoid a rollover race.
Time base is disabled at this point, so it should be moving AT ALL.
- k
PATCH 1/1 85xx: Ensure timebase is zero on secondary cores
Dear Kumar Gala,
Quoted 11 lines · In message <[email protected]> you wrote:
Quoted 9 lines
cpu/mpc85xx/release.S __secondary_start_page: · line 43
Quoted 5 lines
cpu/mpc85xx/release.S +4
-0+ /* Ensure TB is 0 */ + li r3,0 + mttbu r3 + mttbl r3If it's possible that TBL is a small negative number out of reset, then
we should write TBL before TBU to avoid a rollover race.Time base is disabled at this point, so it should be moving AT ALL.
But swapping the two insns shouldn't hurt either.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
News is what a chap who doesn't care much about anything wants to
read. And it's only news until he's read it. After that it's dead.
- Evelyn Waugh _Scoop_ (1938) bk. 1, ch. 5