smc91x: SMC_IO_SHIFT platform data support for default case
Subsystems (3)
PATCH 1/1 smc91x: SMC_IO_SHIFT platform data support for default case
From: Magnus Damm <[email protected]>
Commit 159198862adad7109bb347bb30a620f67beac45f added SMC_IO_SHIFT platform data support. After that ARM board support was added.
The default case is still missing though, so on SuperH SMC_IO_SHIFT is constantly zero regardless of what you pass as platform data.
---
drivers/net/smc91x.h | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/smc91x.h +2 -0
@@ -446,6 +446,8 @@ static inline void LPD7_SMC_outsw (unsig#define SMC_CAN_USE_32BIT 1#define SMC_NOWAIT 1 +#define SMC_IO_SHIFT (lp->io_shift) +#define SMC_inb (a, r) readb((a) + (r))#define SMC_inw (a, r) readw((a) + (r))#define SMC_inl (a, r) readl((a) + (r))
Quoted 7 lines · Magnus Damm
From: Magnus Damm <[email protected]>
Commit
159198862adad7109bb347bb30a620f67beac45faddedSMC_IO_SHIFTplatform data support. After that ARM board support was added.The default case is still missing though, so on SuperH
SMC_IO_SHIFTis constantly zero regardless of what you pass as platform data.
Hi Magnus,
I beleive that its now common practice to include the subject of a commit along with its id, as the latter can change as it moves from tree to tree.
Hi Simon!
Quoted 6 lines · Simon Horman
Quoted 5 lines · Magnus Damm
From: Magnus Damm <[email protected]>
Commit
159198862adad7109bb347bb30a620f67beac45faddedSMC_IO_SHIFTplatform data support. After that ARM board support was added.
Quoted 6 lines
Quoted 2 lines
The default case is still missing though, so on SuperH
SMC_IO_SHIFTis constantly zero regardless of what you pass as platform data.I beleive that its now common practice to include the subject of a commit along with its id, as the latter can change as it moves from tree to tree.
Oh, thanks for pointing that out. I should really do that next time.
In this case the commit id is from the linux-2.6 git, so shouldn't it be stable enough? Isn't it the final destination? =)
Thanks!
/ magnus
Jeff Garzik
AppliedQuoted 18 lines · Magnus Damm
From: Magnus Damm <[email protected]>
Commit
159198862adad7109bb347bb30a620f67beac45faddedSMC_IO_SHIFTplatform data support. After that ARM board support was added.The default case is still missing though, so on SuperH
SMC_IO_SHIFTis constantly zero regardless of what you pass as platform data.Signed-off-by Magnus Damm <[email protected]>Test-by Luca Santini <[email protected]>---
drivers/net/smc91x.h | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/smc91x.h static inline void LPD7_SMC_outsw (unsig · line 453
Quoted 8 lines
drivers/net/smc91x.h +2
-0@@ -446,6 +446,8 @@ static inline void LPD7_SMC_outsw (unsig#define SMC_CAN_USE_32BIT 1#define SMC_NOWAIT 1 +#define SMC_IO_SHIFT (lp->io_shift) +#define SMC_inb (a, r) readb((a) + (r))#define SMC_inw (a, r) readw((a) + (r))#define SMC_inl (a, r) readl((a) + (r))
applied