Skip to contentSkip to conversation

udf: add llseek method

PATCH In review Christoph Hellwig 2 participants 2 messages Sep 8, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 udf: add llseek method

UDF currently doesn't set a llseek method for regular files, which means it will fall back to default_llseek. This means no one can seek beyond 2 Gigabytes on reiserfs, and that there's not protection vs the i_size updates from writers.

fs/udf/file.c +1 -0
Index: linux-2.6/fs/udf/file.c
===================================================================
@@ -211,6 +211,7 @@ const struct file_operations udf_file_op
 	.release		= udf_release_file,
 	.fsync			= udf_fsync_file,
 	.splice_read		= generic_file_splice_read,
+	.llseek			= generic_file_llseek,
 };
 
 const struct inode_operations udf_file_inode_operations = {
reviewer
#1 lore raw
Quoted 4 lines · Christoph Hellwig

UDF currently doesn't set a llseek method for regular files, which means it will fall back to default_llseek. This means no one can seek beyond 2 Gigabytes on reiserfs, and that there's not protection vs the i_size updates from writers.

Thanks. Merged after fixing typo in the changelog (reiserfs -> udf).

Honza

Quoted 14 lines

Index: linux-2.6/fs/udf/file.c
===================================================================

fs/udf/file.c +1 -0
@@ -211,6 +211,7 @@ const struct file_operations udf_file_op
 	.release		= udf_release_file,
 	.fsync			= udf_fsync_file,
 	.splice_read		= generic_file_splice_read,
+	.llseek			= generic_file_llseek,
 };
 
 const struct inode_operations udf_file_inode_operations = {
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR