ti_usb_3410_5052 obviously broken by firmware changes
Subsystems (2)
PATCH 1/1 ti_usb_3410_5052 obviously broken by firmware changes
From: Chris Adams <[email protected]>
While making some other changes to ti_usb_3410_5052, I noticed that the changes made to move the firmware loading to a separate function are broken (in ti_download_firmware(), status is set to -ENOMEM and never changed). This means the driver will never initialize the device properly. It looks like status was supposed to get the result of ti_do_download().
Signed-off-by Chris Adams <[email protected]>
---
It doesn't look like there's a maintainer for this driver other than TI (which has no email listed). Should changes for this go to linux-usb, here, or what?
drivers/usb/serial/ti_usb_3410_5052.c +1 -1
@@ -1744,7 +1744,7 @@ static int ti_download_firmware(struct tif (buffer) {memcpy (buffer, fw_p->data, fw_p->size);memset (buffer + fw_p->size,0xff , buffer_size - fw_p->size); -ti_do_download (dev, pipe, buffer, fw_p->size); + status =ti_do_download (dev, pipe, buffer, fw_p->size);kfree (buffer); }release_firmware (fw_p);