Skip to contentSkip to conversation

qemu_mips: Update linux bootm to support dynamic cmdline

PATCH Superseded Jean-Christophe PLAGNIOL-VILLARD 2 participants 5 messages Sep 8, 2008 – Sep 9, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu_mips: Update linux bootm to support dynamic cmdline

---
 lib_mips/Makefile          |    4 ++
 lib_mips/bootm_qemu_mips.c |   76 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 80 insertions(+), 0 deletions(-)
 create mode 100644 lib_mips/bootm_qemu_mips.c
lib_mips/Makefile +4 -0
index 8176437..7967e58 100644
@@ -28,7 +28,11 @@ LIB	= $(obj)lib$(ARCH).a
 SOBJS-y	+=
 
 COBJS-y	+= board.o
+ifeq ($(CONFIG_QEMU_MIPS),y)
+COBJS-y	+= bootm_qemu_mips.o
+else
 COBJS-y	+= bootm.o
+endif
 COBJS-y	+= time.o
 
 SRCS	:= $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c)
lib_mips/bootm_qemu_mips.c new file +76 -0

76 lines not on this page · raw message

Signature · 1 line
1.5.6.5
#1 lore raw

PATCH v2 1/1 qemu_mips: Update linux bootm to support dynamic cmdline

---
Fix e-mail in copyright

 lib_mips/Makefile          |    4 ++
 lib_mips/bootm_qemu_mips.c |   76 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 80 insertions(+), 0 deletions(-)
 create mode 100644 lib_mips/bootm_qemu_mips.c
lib_mips/Makefile +4 -0
index 8176437..7967e58 100644
@@ -28,7 +28,11 @@ LIB	= $(obj)lib$(ARCH).a
 SOBJS-y	+=
 
 COBJS-y	+= board.o
+ifeq ($(CONFIG_QEMU_MIPS),y)
+COBJS-y	+= bootm_qemu_mips.o
+else
 COBJS-y	+= bootm.o
+endif
 COBJS-y	+= time.o
 
 SRCS	:= $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c)
lib_mips/bootm_qemu_mips.c new file +76 -0

76 lines not on this page · raw message

Signature · 1 line
1.5.6.5
#2 lore raw

PATCH v2 1/1 qemu_mips: Update linux bootm to support dynamic cmdline

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 5 lines · In message <[email protected]> you wrote:

---
Fix e-mail in copyright

 lib_mips/Makefile          |    4 ++
 lib_mips/bootm_qemu_mips.c |   76 ++++++++++++++++++++++++++++++++++++++++++++

Why do we need a completely separate implementation for the bootm command? If this is a true emulation, using the same kernel interface, we should also be able to use the exactly same bootm code?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Pray to God, but keep rowing to shore. - Russian Proverb
#3 lore raw

PATCH v2 1/1 qemu_mips: Update linux bootm to support dynamic cmdline

Quoted 9 lines · Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 5 lines · In message <[email protected]> you wrote:

---
Fix e-mail in copyright

 lib_mips/Makefile          |    4 ++
 lib_mips/bootm_qemu_mips.c |   76 ++++++++++++++++++++++++++++++++++++++++++++
Quoted 3 lines

Why do we need a completely separate implementation for the bootm command? If this is a true emulation, using the same kernel interface, we should also be able to use the exactly same bootm code?

Unfortunaltely not, the qemu_mips have it's own implementation.

To simplify it, I've prefer to sepate them.

Best Regards,
J.

#4 lore raw

PATCH 1/1 qemu_mips: Update linux bootm to support dynamic cmdline

In reply to Jean-Christophe PLAGNIOL-VILLARD

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 6 lines · In message <[email protected]> you wrote:
---
 lib_mips/Makefile          |    4 ++
 lib_mips/bootm_qemu_mips.c |   76 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 80 insertions(+), 0 deletions(-)
 create mode 100644 lib_mips/bootm_qemu_mips.c

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
KLB is an acronym for `Known Lazy Bastard', aka non-FAQ  reader,  aka
person  who  would  rather  make  someone  take their time to explain
something basic than look it up in a  FAQ.
         -- Tom Christiansen in <[email protected]>