Skip to contentSkip to conversation

Correct drv_usb_kbd_init function

PATCH New Ryan CHEN 3 participants 4 messages Aug 20, 2008 – Sep 9, 2008

lore
Share & tools
lore

Ryan CHEN

author
#0 lore raw

PATCH 1/1 Correct drv_usb_kbd_init function

The patch is that check if usb_get_dev_index() function return valid pointer. If valid, continue. Otherwise return -1.

---
 common/usb_kbd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
common/usb_kbd.c +2 -0
index c876495..880e616 100644
@@ -164,6 +164,8 @@ int drv_usb_kbd_init(void)
 	/* scan all USB Devices */
 	for(i=0;i<USB_MAX_DEVICE;i++) {
 		dev=usb_get_dev_index(i); /* get device */
+		if(dev == NULL)
+			return -1;
 		if(dev->devnum!=-1) {
 			if(usb_kbd_probe(dev,0)==1) { /* Ok, we found a keyboard */
 				/* check, if it is already registered */
Signature · 1 line
1.6.0.rc1
#1 lore raw

PATCH 1/1 Correct drv_usb_kbd_init function

while we're at it...

Quoted 4 lines · Ryan CHEN

The patch is that check if usb_get_dev_index() function return valid pointer. If valid, continue. Otherwise return -1.

Wolfgang, please apply!

Best regards
Markus

Signature · 3 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de")
#2 lore raw

PATCH 1/1 Correct drv_usb_kbd_init function

Dear Markus =?iso-8859-1?Q?Klotzb=FCcher?=,

Quoted 11 lines · In message <20080909143531.GB11987@lisa> you wrote:

while we're at it...

Quoted 4 lines · Ryan CHEN

The patch is that check if usb_get_dev_index() function return valid pointer. If valid, continue. Otherwise return -1.

Wolfgang, please apply!

Done, thanks!

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Der Irrtum wiederholt sich immerfort in der Tat.  Deshalb mu? man das
Wahre unerm?dlich in Worten wiederholen.                     - Goethe
#3 lore raw

PATCH 1/1 Correct drv_usb_kbd_init function

In reply to Ryan CHEN

Dear Ryan CHEN,

Quoted 8 lines · In message <[email protected]> you wrote:

The patch is that check if usb_get_dev_index() function return valid pointer. If valid, continue. Otherwise return -1.

---
 common/usb_kbd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"An organization dries up if you don't challenge it with growth."
       - Mark Shepherd, former President and CEO of Texas Instruments