Skip to contentSkip to conversation

forcedeth: option to disable 100Hz timer (try 2)

PATCH Mikhail Kshevetskiy 2 participants 2 messages Sep 9, 2008 – Sep 10, 2008 Network drivers

lore
Share & tools
lore
#0 lore raw

On some hardware no TX done interrupts are generated, thus special 100Hz timer interrupt is required to handle this situation properly. Other device do not require that timer interrupt feature.

Forcedeth has a DEV_NEED_TIMERIRQ flag to mark the broken devices. Unfortunately, nobody know the actual list of broken devices, so all device has this flag on. Other problem, this flag is not user visible, so the kernel recompilation is required to disable timer interrupts and test a device.

This patch add a "disable_timerirq" option to disable interrupt timer mentioned above. This may be extremely useful for laptop users.

Mikhail Kshevetskiy

drivers/net/forcedeth.c renamed from drivers/net/forcedeth.c.orig +13 -1
@@ -842,6 +842,16 @@
 static int poll_interval = -1;
 
 /*
+ * On some hardware no TX done interrupts are generated, thus special
+ * timer interrupt is required to handle this situation properly.
+ *
+ * Setting this variable to 1 leads to removing DEV_NEED_TIMERIRQ from
+ * the driver_data flags and thus disable 100Hz timer mentioned above.
+ * This may be extremely usefull for laptop users.
+ */
+static int disable_timerirq = 0;
+
+/*
  * MSI interrupts
  */
 enum {
@@ -5704,7 +5714,7 @@
 			np->msi_flags |= 0x0001;
 	}
 
-	if (id->driver_data & DEV_NEED_TIMERIRQ)
+	if (id->driver_data & DEV_NEED_TIMERIRQ && !disable_timerirq)
 		np->irqmask |= NVREG_IRQ_TIMER;
 	if (id->driver_data & DEV_NEED_LINKTIMER) {
 		dprintk(KERN_INFO "%s: link timer on.\n", pci_name(pci_dev));
@@ -6180,6 +6190,8 @@
 MODULE_PARM_DESC(dma_64bit, "High DMA is enabled by setting to 1 and disabled by setting to 0.");
 module_param(phy_cross, int, 0);
 MODULE_PARM_DESC(phy_cross, "Phy crossover detection for Realtek 8201 phy is enabled by setting to 1 and disabled by setting to 0.");
+module_param(disable_timerirq, int, 0);
+MODULE_PARM_DESC(disable_timerirq, "100Hz timer required for some hardware is disabled by setting to 1 and enabled by setting to 0.");
 
 MODULE_AUTHOR("Manfred Spraul <[email protected]>");
 MODULE_DESCRIPTION("Reverse Engineered nForce ethernet driver");
#1 lore raw
Quoted 5 lines · On Tue, 9 Sep 2008 23:34:35 +0400 Mikhail Kshevetskiy…

On some hardware no TX done interrupts are generated, thus special 100Hz timer interrupt is required to handle this situation properly. Other device do not require that timer interrupt feature.

Quoted 8 lines

Forcedeth has a DEV_NEED_TIMERIRQ flag to mark the broken devices. Unfortunately, nobody know the actual list of broken devices, so all device has this flag on. Other problem, this flag is not user visible, so the kernel recompilation is required to disable timer interrupts and test a device.

This patch add a "disable_timerirq" option to disable interrupt timer mentioned above. This may be extremely useful for laptop users.

Why do you feel that the timer-based completions need to be disabled? Is it causing some problem?