Skip to contentSkip to conversation

fastboot: fix blackfin breakage due to vmlinux.lds change

PATCH In review Arjan van de Ven 3 participants 3 messages Sep 10, 2008 – Sep 11, 2008 Generic include/asm header files

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fastboot: fix blackfin breakage due to vmlinux.lds change

Hi,

the patch below fixes the fastboot bug as reported by Mike Frysinger; I've commited this to
git://git.kernel.org/pub/scm/linux/kernel/git/arjan/linux-2.6-fastboot.git

Ingo, please also add to -tip

Quoted 1 line

From 16aeda33acbb711863d8fff78c15b32ad0d4aa89 Mon Sep 17 00:00:00 2001

From: Arjan van de Ven <[email protected]>
Date: Wed, 10 Sep 2008 08:22:26 -0700
Subject: [PATCH] fastboot: fix blackfin breakage due to vmlinux.lds change

As reported by Mike Frysinger, the vmlinux.lds changes should have used VMLINUX_SYMBOL()...

---
 include/asm-generic/vmlinux.lds.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/asm-generic/vmlinux.lds.h +3 -3
index 020c641..f32418f 100644
@@ -373,11 +373,11 @@
   	*(.initcall5s.init)						\
 	*(.initcallrootfs.init)						\
 	*(.initcall6s.init)						\
-	__async_initcall_start = .;					\
+	VMLINUX_SYMBOL(__async_initcall_start) = .;			\
 	*(.initcall6a.init)						\
-	__async_initcall_end = .;					\
+	VMLINUX_SYMBOL(__async_initcall_end) = .;			\
   	*(.initcall6.init)						\
-	__device_initcall_end = .;					\
+	VMLINUX_SYMBOL(__device_initcall_end) = .;			\
   	*(.initcall7.init)						\
   	*(.initcall7s.init)
 
Signature · 9 lines
1.5.5.1




-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Arjan van de Ven

Hi,

the patch below fixes the fastboot bug as reported by Mike Frysinger; I've commited this to
git://git.kernel.org/pub/scm/linux/kernel/git/arjan/linux-2.6-fastboot.git

Ingo, please also add to -tip

Quoted 8 lines

From 16aeda33acbb711863d8fff78c15b32ad0d4aa89 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Wed, 10 Sep 2008 08:22:26 -0700
Subject: [PATCH] fastboot: fix blackfin breakage due to vmlinux.lds change

As reported by Mike Frysinger, the vmlinux.lds changes should have used VMLINUX_SYMBOL()...

Thanks a lot, Mike and Arjan. This issue was found by Mike's auto nightly building machine.

Quoted 41 lines
---
 include/asm-generic/vmlinux.lds.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/asm-generic/vmlinux.lds.h +3 -4
index 020c641..f32418f 100644
@@ -373,11 +373,11 @@
       *(.initcall5s.init)                                             \
       *(.initcallrootfs.init)                                         \
       *(.initcall6s.init)                                             \
-       __async_initcall_start = .;                                     \
+       VMLINUX_SYMBOL(__async_initcall_start) = .;                     \
       *(.initcall6a.init)                                             \
-       __async_initcall_end = .;                                       \
+       VMLINUX_SYMBOL(__async_initcall_end) = .;                       \
       *(.initcall6.init)                                              \
-       __device_initcall_end = .;                                      \
+       VMLINUX_SYMBOL(__device_initcall_end) = .;                      \
       *(.initcall7.init)                                              \
       *(.initcall7s.init)
 
--

1.5.5.1

--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 15 lines · Bryan Wu
Quoted 14 lines · Arjan van de Ven

Hi,

the patch below fixes the fastboot bug as reported by Mike Frysinger; I've commited this to
git://git.kernel.org/pub/scm/linux/kernel/git/arjan/linux-2.6-fastboot.git

Ingo, please also add to -tip

From 16aeda33acbb711863d8fff78c15b32ad0d4aa89 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Wed, 10 Sep 2008 08:22:26 -0700
Subject: [PATCH] fastboot: fix blackfin breakage due to vmlinux.lds change

Quoted 8 lines
Quoted 3 lines

As reported by Mike Frysinger, the vmlinux.lds changes should have used VMLINUX_SYMBOL()...

Thanks a lot, Mike and Arjan. This issue was found by Mike's auto nightly building machine.

applied to tip/fastboot, thanks!

Ingo