Skip to contentSkip to conversation

Clean up for MSR_IA32_FEATURE_CONTROL

PATCH In review Sheng Yang 2 participants 3 messages Sep 11, 2008

lore
Share & tools
lore

Sheng Yang

author
#0 lore raw

cover Clean up for MSR_IA32_FEATURE_CONTROL

Hi, Ingo

Here is some follow up clean up for "Move VMX MSRs to msr-index.h". After discussion with Avi, I found it's more proper to move MSR_IA32_FEATURE_CONTROL bits to msr-index.h as well.

But I got a little puzzle about where to accept these patches. I suppose these can be picked up by tip then go with kvm when it merge upstream? The main problem is macro name changed to keep consistent style.

Thanks!
--
regards
Yang, Sheng

#1 lore raw
Quoted 10 lines · Sheng Yang

Hi, Ingo

Here is some follow up clean up for "Move VMX MSRs to msr-index.h". After discussion with Avi, I found it's more proper to move MSR_IA32_FEATURE_CONTROL bits to msr-index.h as well.

But I got a little puzzle about where to accept these patches. I suppose these can be picked up by tip then go with kvm when it merge upstream? The main problem is macro name changed to keep consistent style.

there's a few changes pending for that file:

earth4:~/tip> gll linus.. include/asm-x86/msr-index.h 315a655: x86: move VMX MSRs to msr-index.h 77ef50a: x86: consolidate header guards

so i guess best is to put 315a655 into kvm.git as well and do these changes there. The header-guard changes should not cause significant merge trouble.

Ingo

#2 lore raw
Quoted 14 lines · On Thursday 11 September 2008 14:35:23 Ingo Molnar wrote:
Quoted 10 lines · Sheng Yang

Hi, Ingo

Here is some follow up clean up for "Move VMX MSRs to msr-index.h". After discussion with Avi, I found it's more proper to move MSR_IA32_FEATURE_CONTROL bits to msr-index.h as well.

But I got a little puzzle about where to accept these patches. I suppose these can be picked up by tip then go with kvm when it merge upstream? The main problem is macro name changed to keep consistent style.

there's a few changes pending for that file:

Quoted 8 lines

earth4:~/tip> gll linus.. include/asm-x86/msr-index.h 315a655: x86: move VMX MSRs to msr-index.h 77ef50a: x86: consolidate header guards

so i guess best is to put 315a655 into kvm.git as well and do these changes there. The header-guard changes should not cause significant merge trouble.

OK, I will resend the patches to KVM mailing list(o, forgot to CC them here...)

Thanks!

Signature · 2 lines
regards
Yang, Sheng
Quoted 6 lines

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/