spi_s3c24xx: fix section warning

PATCH In review David Brownell 3 participants 4 messages Sep 12, 2008 – Sep 14, 2008 3 messages not in the archive

Subsystems (3)

Library code SPI Arm Samsung Exynos

lore

Share & tools

lore

David Brownell

author

2008-09-12 16:44 UTC #0 lore raw

PATCH 1/1 spi_s3c24xx: fix section warning

From: Ben Dooks <[email protected]>

Fix the section mismatch warning generated by the iconrrect naming of s3c24xx_spidrv which should be s3c24xx_spi_driver:

WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4):
Section mismatch in reference from the variable s3c24xx_spidrv to the (unknown reference) .exit.text:(unknown)

Signed-off-by Ben Dooks <[email protected]>

Signed-off-by David Brownell <[email protected]>

---
 drivers/spi/spi_s3c24xx.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/spi/spi_s3c24xx.c +3 -3

@@ -436,7 +436,7 @@ static int s3c24xx_spi_resume(struct pla
 #endif
 
 MODULE_ALIAS("platform:s3c2410-spi");
-static struct platform_driver s3c24xx_spidrv = {
+static struct platform_driver s3c24xx_spi_driver = {
 	.remove		= __exit_p(s3c24xx_spi_remove),
 	.suspend	= s3c24xx_spi_suspend,
 	.resume		= s3c24xx_spi_resume,

@@ -448,12 +448,12 @@ static struct platform_driver s3c24xx_sp
 
 static int __init s3c24xx_spi_init(void)
 {
-        return platform_driver_probe(&s3c24xx_spidrv, s3c24xx_spi_probe);
+        return platform_driver_probe(&s3c24xx_spi_driver, s3c24xx_spi_probe);
 }
 
 static void __exit s3c24xx_spi_exit(void)
 {
-        platform_driver_unregister(&s3c24xx_spidrv);
+        platform_driver_unregister(&s3c24xx_spi_driver);
 }
 
 module_init(s3c24xx_spi_init);

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

A message that is not in the archive (sent off-list or not yet received): 200809120944.13918.david-b-yBeKhBN/[email protected]

Andrew Morton

2008-09-12 22:52 UTC #2 lore raw

Quoted 31 lines · On Fri, 12 Sep 2008 09:44:13 -0700 David Brownell…

From: Ben Dooks <[email protected]>
Fix the section mismatch warning generated by the iconrrect naming of s3c24xx_spidrv which should be s3c24xx_spi_driver:
WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4):
Section mismatch in reference from the variable s3c24xx_spidrv to the (unknown reference) .exit.text:(unknown)
Signed-off-by Ben Dooks <[email protected]>
Signed-off-by David Brownell <[email protected]>
---
 drivers/spi/spi_s3c24xx.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/spi/spi_s3c24xx.c +1 -2
@@ -436,7 +436,7 @@ static int s3c24xx_spi_resume(struct pla
 #endif
 
 MODULE_ALIAS("platform:s3c2410-spi");
-static struct platform_driver s3c24xx_spidrv = {
+static struct platform_driver s3c24xx_spi_driver = {
 	.remove		= __exit_p(s3c24xx_spi_remove),
 	.suspend	= s3c24xx_spi_suspend,
 	.resume		= s3c24xx_spi_resume,
@@ -448,12 +448,12 @@ static struct platform_driver s3c24xx_sp
 
 static int __init s3c24xx_spi_init(void)
 {
-        return platform_driver_probe(&s3c24xx_spidrv, s3c24xx_spi_probe);

drivers/spi/spi_s3c24xx.c static struct platform_driver s3c24xx_sp · line 459

Quoted 10 lines

drivers/spi/spi_s3c24xx.c +2 -1

+        return platform_driver_probe(&s3c24xx_spi_driver, s3c24xx_spi_probe);
 }
 
 static void __exit s3c24xx_spi_exit(void)
 {
-        platform_driver_unregister(&s3c24xx_spidrv);
+        platform_driver_unregister(&s3c24xx_spi_driver);
 }
 
 module_init(s3c24xx_spi_init);

whoa. We have kbuild magic which relies unpn a name ending in "_driver"?

Why did I just learn that. Do you know if this magic is described anywhere?

Thanks.

A message that is not in the archive (sent off-list or not yet received): 20080912155200.3f58c477.akpm-de/[email protected]

David Brownell

author

2008-09-12 23:54 UTC #4 lore raw

Quoted 12 lines · Andrew Morton

Quoted 9 lines · On Fri, 12 Sep 2008 09:44:13 -0700 David Brownell…
From: Ben Dooks <[email protected]>
Fix the section mismatch warning generated by the iconrrect naming of s3c24xx_spidrv which should be s3c24xx_spi_driver:
WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4):
Section mismatch in reference from the variable s3c24xx_spidrv to the (unknown reference) .exit.text:(unknown)

Quoted 6 lines

Quoted 1 line
...
whoa. We have kbuild magic which relies unpn a name ending in "_driver"?
Why did I just learn that. Do you know if this magic is described anywhere?

You probably just learned that because you have better things to do than run with the appended patch, and then fixing the resulting warnings (sample shown above) according to the magic handwaving at secref_whitelist() in scripts/mod/modpost.c ...

---
 lib/Kconfig.debug |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

lib/Kconfig.debug +1 -1

@@ -95,7 +95,7 @@ config HEADERS_CHECK
 
 config DEBUG_SECTION_MISMATCH
 	bool "Enable full Section mismatch analysis"
-	depends on UNDEFINED
+	# depends on UNDEFINED
 	# This option is on purpose disabled for now.
 	# It will be enabled when we are down to a resonable number
 	# of section mismatch warnings (< 10 for an allyesconfig build)

A message that is not in the archive (sent off-list or not yet received): 200809121654.08873.david-b-yBeKhBN/[email protected]

Ben Dooks

2008-09-14 21:01 UTC #6 lore raw

Quoted 32 lines · David Brownell

Quoted 12 lines · Andrew Morton
Quoted 9 lines · On Fri, 12 Sep 2008 09:44:13 -0700 David Brownell…
From: Ben Dooks <[email protected]>
Fix the section mismatch warning generated by the iconrrect naming of s3c24xx_spidrv which should be s3c24xx_spi_driver:
WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4):
Section mismatch in reference from the variable s3c24xx_spidrv to the (unknown reference) .exit.text:(unknown)
Quoted 6 lines
Quoted 1 line
...
whoa. We have kbuild magic which relies unpn a name ending in "_driver"?
Why did I just learn that. Do you know if this magic is described anywhere?
You probably just learned that because you have better things to do than run with the appended patch, and then fixing the resulting warnings (sample shown above) according to the magic handwaving at secref_whitelist() in scripts/mod/modpost.c ...
---
 lib/Kconfig.debug |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

lib/Kconfig.debug config HEADERS_CHECK · line 101

Quoted 8 lines

lib/Kconfig.debug +1 -1

@@ -95,7 +95,7 @@ config HEADERS_CHECK
 
 config DEBUG_SECTION_MISMATCH
 	bool "Enable full Section mismatch analysis"
-	depends on UNDEFINED
+	# depends on UNDEFINED
 	# This option is on purpose disabled for now.
 	# It will be enabled when we are down to a resonable number
 	# of section mismatch warnings (< 10 for an allyesconfig build)

I have something similar in my tree. It would be nice to sort this out so it wasn't disabled by default.

Signature · 11 lines

Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/