Skip to contentSkip to conversation

retain ABI definitions for obsolete multi-queue packet schedulers

PATCH In review Stephen Hemminger 2 participants 6 messages Sep 12, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 retain ABI definitions for obsolete multi-queue packet schedulers

Even though the sch_rr qdisc is now gone in 2.6.27, the kernel definitions for the attributes need to be maintained because applications like iproute need to be compatible with older kernels and use santized kernel headers.

include/linux/pkt_sched.h +10 -0
@@ -123,6 +123,16 @@ struct tc_prio_qopt
 	__u8	priomap[TC_PRIO_MAX+1];	/* Map: logical priority -> PRIO band */
 };
 
+/* Obsolete option from original multiqueue */
+enum
+{
+	TCA_PRIO_UNSPEC,
+	TCA_PRIO_MQ,
+	__TCA_PRIO_MAX
+};
+
+#define TCA_PRIO_MAX    (__TCA_PRIO_MAX - 1)
+
 /* TBF section */
 
 struct tc_tbf_qopt
#1 lore raw
Quoted 27 lines · On Fri, 12 Sep 2008 10:00:11 -0700 Stephen Hemminger <[email protected]>…

Even though the sch_rr qdisc is now gone in 2.6.27, the kernel definitions for the attributes need to be maintained because applications like iproute need to be compatible with older kernels and use santized kernel headers.

include/linux/pkt_sched.h +10 -1
@@ -123,6 +123,16 @@ struct tc_prio_qopt
 	__u8	priomap[TC_PRIO_MAX+1];	/* Map: logical priority -> PRIO band */
 };
 
+/* Obsolete option from original multiqueue */
+enum
+{
+	TCA_PRIO_UNSPEC,
+	TCA_PRIO_MQ,
+	__TCA_PRIO_MAX
+};
+
+#define TCA_PRIO_MAX    (__TCA_PRIO_MAX - 1)
+
 /* TBF section */
 
 struct tc_tbf_qopt
--
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

This should be applied for 2.6.27 since it is a build regression.

maintainer
#2 lore raw

From: Stephen Hemminger <[email protected]>
Date: Fri, 12 Sep 2008 12:25:48 -0700

Quoted 7 lines
Quoted 4 lines · On Fri, 12 Sep 2008 10:00:11 -0700 Stephen Hemminger <[email protected]>…

Even though the sch_rr qdisc is now gone in 2.6.27, the kernel definitions for the attributes need to be maintained because applications like iproute need to be compatible with older kernels and use santized kernel headers.

...

Quoted 1 line

This should be applied for 2.6.27 since it is a build regression.

You use a local copy of this header file in iproute2, you don't even use the kernel header itself. It's the worst possible example and excuse for this change.

Nobody references this header directly for these definitions. The one and only use is using a local copy.

iproute2 is the only thing even remotely referencing this stuff.

So there is no breakage. The only breakage is if you, Stephen, decide to copy the kernel header into iproute2 as-is, and that is your choice. :-)

#3 lore raw
Quoted 17 lines · On Fri, 12 Sep 2008 15:30:33 -0700 (PDT) David Miller <[email protected]>…

From: Stephen Hemminger <[email protected]>
Date: Fri, 12 Sep 2008 12:25:48 -0700

Quoted 7 lines
Quoted 4 lines · On Fri, 12 Sep 2008 10:00:11 -0700 Stephen Hemminger <[email protected]>…

Even though the sch_rr qdisc is now gone in 2.6.27, the kernel definitions for the attributes need to be maintained because applications like iproute need to be compatible with older kernels and use santized kernel headers.

...

Quoted 1 line

This should be applied for 2.6.27 since it is a build regression.

You use a local copy of this header file in iproute2, you don't even use the kernel header itself. It's the worst possible example and excuse for this change.

Quoted 8 lines

Nobody references this header directly for these definitions. The one and only use is using a local copy.

iproute2 is the only thing even remotely referencing this stuff.

So there is no breakage. The only breakage is if you, Stephen, decide to copy the kernel header into iproute2 as-is, and that is your choice. :-)

Every release I copy the sanitized kernel headers resulting from 'make headers_install'. That is how they have been maintained and up until now it worked. The sch_rr configuration portion was referencing this. The point of the sanitized headers was to avoid this nonsense.

maintainer
#4 lore raw

From: Stephen Hemminger <[email protected]>
Date: Fri, 12 Sep 2008 15:58:30 -0700

Quoted 25 lines
Quoted 22 lines · On Fri, 12 Sep 2008 15:30:33 -0700 (PDT) David Miller <[email protected]>…

From: Stephen Hemminger <[email protected]>
Date: Fri, 12 Sep 2008 12:25:48 -0700

Quoted 7 lines
Quoted 4 lines · On Fri, 12 Sep 2008 10:00:11 -0700 Stephen Hemminger <[email protected]>…

Even though the sch_rr qdisc is now gone in 2.6.27, the kernel definitions for the attributes need to be maintained because applications like iproute need to be compatible with older kernels and use santized kernel headers.

...

Quoted 1 line

This should be applied for 2.6.27 since it is a build regression.

You use a local copy of this header file in iproute2, you don't even use the kernel header itself. It's the worst possible example and excuse for this change.

Nobody references this header directly for these definitions. The one and only use is using a local copy.

iproute2 is the only thing even remotely referencing this stuff.

Quoted 8 lines
Quoted 3 lines

So there is no breakage. The only breakage is if you, Stephen, decide to copy the kernel header into iproute2 as-is, and that is your choice. :-)

Every release I copy the sanitized kernel headers resulting from 'make headers_install'. That is how they have been maintained and up until now it worked. The sch_rr configuration portion was referencing this. The point of the sanitized headers was to avoid this nonsense.

But here is the flip side, we actually don't want new applications referencing those things, since no kernel from now and into the future will ever support those knobs again. They will always fail.

Therefore, it makes sense to put the definitions into the one existing tool that used it. You can even put those defines directly into the sch_rr iproute2 code, and then your sanitized header bits will continue to work transparently.

#5 lore raw
Quoted 37 lines · On Fri, 12 Sep 2008 16:01:54 -0700 (PDT) David Miller <[email protected]>…

From: Stephen Hemminger <[email protected]>
Date: Fri, 12 Sep 2008 15:58:30 -0700

Quoted 25 lines
Quoted 22 lines · On Fri, 12 Sep 2008 15:30:33 -0700 (PDT) David Miller <[email protected]>…

From: Stephen Hemminger <[email protected]>
Date: Fri, 12 Sep 2008 12:25:48 -0700

Quoted 7 lines
Quoted 4 lines · On Fri, 12 Sep 2008 10:00:11 -0700 Stephen Hemminger <[email protected]>…

Even though the sch_rr qdisc is now gone in 2.6.27, the kernel definitions for the attributes need to be maintained because applications like iproute need to be compatible with older kernels and use santized kernel headers.

...

Quoted 1 line

This should be applied for 2.6.27 since it is a build regression.

You use a local copy of this header file in iproute2, you don't even use the kernel header itself. It's the worst possible example and excuse for this change.

Nobody references this header directly for these definitions. The one and only use is using a local copy.

iproute2 is the only thing even remotely referencing this stuff.

Quoted 8 lines
Quoted 3 lines

So there is no breakage. The only breakage is if you, Stephen, decide to copy the kernel header into iproute2 as-is, and that is your choice. :-)

Every release I copy the sanitized kernel headers resulting from 'make headers_install'. That is how they have been maintained and up until now it worked. The sch_rr configuration portion was referencing this. The point of the sanitized headers was to avoid this nonsense.

Quoted 9 lines

But here is the flip side, we actually don't want new applications referencing those things, since no kernel from now and into the future will ever support those knobs again. They will always fail.

Therefore, it makes sense to put the definitions into the one existing tool that used it. You can even put those defines directly into the sch_rr iproute2 code, and then your sanitized header bits will continue to work transparently.

More likely, I'll just drop sch_rr support from the utilities. They were just a flash in the pan for a brief period.