Skip to contentSkip to conversation

IA64: do not include uncached memory to vmcore

PATCH In review Jay Lan 2 participants 3 messages Sep 12, 2008 – Sep 23, 2008

Subsystems (2)
lore
Share & tools
lore

Jay Lan

author
#0 lore raw

PATCH 1/1 IA64: do not include uncached memory to vmcore

Currently a memory segment in memory map with attribute of EFI_MEMORY_UC is denoted as "System RAM" in /proc/iomem, while memory of attribute (EFI_MEMORY_WB|EFI_MEMORY_UC) is also labeled the same.

The kexec utility then includes uncached memory as part of vmcore. The kdump kernel may MCA when it tries to save the vmcore to a disk. A normal "cached" access can cause MCAs.

Since kexec assembled memory ranges with memory tagged as "System RAM", the uncached memory will be excluded if it is labeled differently.

Simon, since only IA64 will create "Uncached RAM" label, i do not make changes to other arch.

Our HP machine in the lab is dead. I am sorry that i can not test against other IA64 systems (than SGI's). Feedback is very much appreciated.

The corresponding kernel patch is needed to test this kexec patch:
http://marc.info/?l=linux-ia64&m=122122791230130&w=2
This patch without the kernel patch will have no effect and do no harm.

---
 kexec/arch/ia64/crashdump-ia64.c     |    5 ++++-
 kexec/arch/ia64/kexec-ia64.c         |    5 ++++-
 kexec/firmware_memmap.c              |    2 ++
 kexec/kexec.h                        |    1 +
 11 files changed, 27 insertions(+), 3 deletions(-)
kexec/arch/ia64/crashdump-ia64.c +4 -1
Index: kexec-tools/kexec/arch/ia64/crashdump-ia64.c
===================================================================
@@ -212,8 +212,11 @@ static int get_crash_memory_ranges(struc
 			kernel_code_start = start;
 			kernel_code_end = end;
 			continue;
-		}else
+		} else if (memcmp(str, "Uncached RAM\n", 13) == 0) {
+			type = RANGE_UNCACHED;
+		} else {
 			continue;
+		}
 		crash_memory_range[memory_ranges].start = start;
 		crash_memory_range[memory_ranges].end = end;
 		crash_memory_range[memory_ranges].type = type;
kexec/kexec.h +1 -0
Index: kexec-tools/kexec/kexec.h
===================================================================
@@ -110,6 +110,7 @@ struct memory_range {
 #define RANGE_RESERVED	1
 #define RANGE_ACPI	2
 #define RANGE_ACPI_NVS	3
+#define RANGE_UNCACHED	4
 };
 
 struct kexec_info {
kexec/arch/ia64/kexec-ia64.c +4 -1
Index: kexec-tools/kexec/arch/ia64/kexec-ia64.c
===================================================================
@@ -139,8 +139,11 @@ int get_memory_ranges(struct memory_rang
 			memory_ranges = split_range(memory_ranges, start, end);
 			saved_efi_memmap_size = end - start;
 			continue;
-		} else
+		} else if (memcmp(str, "Uncached RAM\n", 13) == 0) {
+			type = RANGE_UNCACHED;
+		} else {
 			continue;
+		}
 		/*
 		 * Check if this memory range can be coalesced with
 		 * the previous range
kexec/firmware_memmap.c +2 -0
Index: kexec-tools/kexec/firmware_memmap.c
===================================================================
@@ -158,6 +158,8 @@ static int parse_memmap_entry(const char
 		range->type = RANGE_RESERVED;
 	else if (strcmp(type, "ACPI Non-volatile Storage") == 0)
 		range->type = RANGE_ACPI_NVS;
+	else if (strcmp(type, "Uncached RAM") == 0)
+		range->type = RANGE_UNCACHED;
 	else {
 		fprintf(stderr, "Unknown type (%s) while parsing %s. Please "
 			"report this as bug. Using RANGE_RESERVED now.\n",

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#1 lore raw
Quoted 14 lines · Jay Lan

Currently a memory segment in memory map with attribute of EFI_MEMORY_UC is denoted as "System RAM" in /proc/iomem, while memory of attribute (EFI_MEMORY_WB|EFI_MEMORY_UC) is also labeled the same.

The kexec utility then includes uncached memory as part of vmcore. The kdump kernel may MCA when it tries to save the vmcore to a disk. A normal "cached" access can cause MCAs.

Since kexec assembled memory ranges with memory tagged as "System RAM", the uncached memory will be excluded if it is labeled differently.

Simon, since only IA64 will create "Uncached RAM" label, i do not make changes to other arch.

Quoted 8 lines

Our HP machine in the lab is dead. I am sorry that i can not test against other IA64 systems (than SGI's). Feedback is very much appreciated.

The corresponding kernel patch is needed to test this kexec patch:
http://marc.info/?l=linux-ia64&m2122791230130&w=2
This patch without the kernel patch will have no effect and do no harm.

Hi Jay,

both of these patches seem reasonable to me, especially from a kexec point of view. I will try and test them on an HP RX2620 and Intel Tiger 4 and get back to you shortly.

Signature · 3 lines
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en
#2 lore raw
Quoted 24 lines · Simon Horman
Quoted 14 lines · Jay Lan

Currently a memory segment in memory map with attribute of EFI_MEMORY_UC is denoted as "System RAM" in /proc/iomem, while memory of attribute (EFI_MEMORY_WB|EFI_MEMORY_UC) is also labeled the same.

The kexec utility then includes uncached memory as part of vmcore. The kdump kernel may MCA when it tries to save the vmcore to a disk. A normal "cached" access can cause MCAs.

Since kexec assembled memory ranges with memory tagged as "System RAM", the uncached memory will be excluded if it is labeled differently.

Simon, since only IA64 will create "Uncached RAM" label, i do not make changes to other arch.

Quoted 8 lines

Our HP machine in the lab is dead. I am sorry that i can not test against other IA64 systems (than SGI's). Feedback is very much appreciated.

The corresponding kernel patch is needed to test this kexec patch:
http://marc.info/?l=linux-ia64&m2122791230130&w=2
This patch without the kernel patch will have no effect and do no harm.

Quoted 5 lines

Hi Jay,

both of these patches seem reasonable to me, especially from a kexec point of view. I will try and test them on an HP RX2620 and Intel Tiger 4 and get back to you shortly.

Hi Jay, Hi All,

As "[IA64] kexec fails on systems with blocks of uncached memory" has been applied to the kernel by Tony and pulled by Linus, I have applied this kexec-tools portion of the patch.

Signature · 3 lines
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en