ibmasr: remove unnecessary spin_unlock()
PATCH 1/1 ibmasr: remove unnecessary spin_unlock()
__asr_toggle() is always called with asr_lock held. But there is unnecessary spin_unlock() call in __asr_toggle().
Signed-off-by Akinobu Mita <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
Cc Andrey Panin <[email protected]>
--- drivers/watchdog/ibmasr.c | 1 - 1 file changed, 1 deletion(-)
drivers/watchdog/ibmasr.c +0 -1
@@ -85,7 +85,6 @@ static void __asr_toggle(void)outb (reg & ~asr_toggle_mask, asr_write_addr); reg =inb (asr_read_addr); -spin_unlock (&asr_lock); }static void asr_toggle (void )
Quoted 6 lines · Akinobu Mita
__asr_toggle()is always called withasr_lockheld. But there is unnecessaryspin_unlock()call in__asr_toggle().Signed-off-by Akinobu Mita <[email protected]>Cc Wim Van Sebroeck <[email protected]>Cc Andrey Panin <[email protected]>
Acked-by Andrey Panin <[email protected]>
Quoted 17 lines
--- drivers/watchdog/ibmasr.c | 1 - 1 file changed, 1 deletion(-)Index:
2.6-git/drivers/watchdog/ibmasr.c
===================================================================drivers/watchdog/ibmasr.c +0
-1@@ -85,7 +85,6 @@ static void __asr_toggle(void)outb (reg & ~asr_toggle_mask, asr_write_addr); reg =inb (asr_read_addr); -spin_unlock (&asr_lock); }static void asr_toggle (void )
Signature · 2 lines
Andrey Panin | Linux and UNIX system administrator [email protected] | PGP key: wwwkeys.pgp.net