Skip to contentSkip to conversation

ibmasr: remove unnecessary spin_unlock()

PATCH In review Akinobu Mita 2 participants 2 messages Sep 13, 2008 – Sep 15, 2008 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ibmasr: remove unnecessary spin_unlock()

__asr_toggle() is always called with asr_lock held. But there is unnecessary spin_unlock() call in __asr_toggle().

Cc Wim Van Sebroeck <[email protected]>
Cc Andrey Panin <[email protected]>
---
 drivers/watchdog/ibmasr.c |    1 -
 1 file changed, 1 deletion(-)
drivers/watchdog/ibmasr.c +0 -1
Index: 2.6-git/drivers/watchdog/ibmasr.c
===================================================================
@@ -85,7 +85,6 @@ static void __asr_toggle(void)
 
 	outb(reg & ~asr_toggle_mask, asr_write_addr);
 	reg = inb(asr_read_addr);
-	spin_unlock(&asr_lock);
 }
 
 static void asr_toggle(void)
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Akinobu Mita

__asr_toggle() is always called with asr_lock held. But there is unnecessary spin_unlock() call in __asr_toggle().

Cc Wim Van Sebroeck <[email protected]>
Cc Andrey Panin <[email protected]>
Quoted 17 lines
---
 drivers/watchdog/ibmasr.c |    1 -
 1 file changed, 1 deletion(-)

Index: 2.6-git/drivers/watchdog/ibmasr.c
===================================================================

drivers/watchdog/ibmasr.c +0 -1
@@ -85,7 +85,6 @@ static void __asr_toggle(void)
 
 	outb(reg & ~asr_toggle_mask, asr_write_addr);
 	reg = inb(asr_read_addr);
-	spin_unlock(&asr_lock);
 }
 
 static void asr_toggle(void)
Signature · 2 lines
Andrey Panin		| Linux and UNIX system administrator
[email protected]		| PGP key: wwwkeys.pgp.net