Skip to contentSkip to conversation

eeepc: depends on RFKILL

PATCH In review Randy Dunlap 2 participants 2 messages Sep 15, 2008 – Sep 16, 2008 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eeepc: depends on RFKILL

From: Randy Dunlap <[email protected]>

EEEPC_LAPTOP uses RFKILL, so the former should depend on RFKILL. Build errors happen when EEEPC_LAPTOP=y and RFKILL=m.

eeepc-laptop.c:(.text+0xd5a7b): undefined reference to rfkill_allocate' eeepc-laptop.c:(.text+0xd5b04): undefined reference to rfkill_register' eeepc-laptop.c:(.text+0xd5b48): undefined reference to rfkill_allocate' eeepc-laptop.c:(.text+0xd5bd4): undefined reference to rfkill_register' eeepc-laptop.c:(.text+0xd5ece): undefined reference to rfkill_unregister' eeepc-laptop.c:(.text+0xd5ef6): undefined reference to rfkill_unregister' make[1]: *** [.tmp_vmlinux1] Error 1

cc Corentin Chary <[email protected]>
---
 drivers/misc/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/misc/Kconfig +1 -0
@@ -410,6 +410,7 @@ config EEEPC_LAPTOP
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on HWMON
 	depends on EXPERIMENTAL
+	depends on RFKILL
 	---help---
 	  This driver supports the Fn-Fx keys on Eee PC laptops.
 	  It also adds the ability to switch camera/wlan on/off.
#1 lore raw

Yep, it should depends on RFKILL, and I should start porting asus-laptop to rfkill.
Thanks for this patch.

Quoted 30 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

EEEPC_LAPTOP uses RFKILL, so the former should depend on RFKILL. Build errors happen when EEEPC_LAPTOP=y and RFKILL=m.

eeepc-laptop.c:(.text+0xd5a7b): undefined reference to rfkill_allocate' eeepc-laptop.c:(.text+0xd5b04): undefined reference to rfkill_register' eeepc-laptop.c:(.text+0xd5b48): undefined reference to rfkill_allocate' eeepc-laptop.c:(.text+0xd5bd4): undefined reference to rfkill_register' eeepc-laptop.c:(.text+0xd5ece): undefined reference to rfkill_unregister' eeepc-laptop.c:(.text+0xd5ef6): undefined reference to rfkill_unregister' make[1]: *** [.tmp_vmlinux1] Error 1

cc Corentin Chary <[email protected]>
---
 drivers/misc/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/misc/Kconfig +1 -0
@@ -410,6 +410,7 @@ config EEEPC_LAPTOP
       depends on BACKLIGHT_CLASS_DEVICE
       depends on HWMON
       depends on EXPERIMENTAL
+       depends on RFKILL
       ---help---
         This driver supports the Fn-Fx keys on Eee PC laptops.
         It also adds the ability to switch camera/wlan on/off.