Skip to contentSkip to conversation

PCI: Fix pcie_aspm=force

PATCH In review Sitsofe Wheeler 3 participants 4 messages Sep 16, 2008 – Sep 23, 2008 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: Fix pcie_aspm=force

From: Sitsofe Wheeler <[email protected]>

pcie_aspm=force did not work because aspm_force was being double negated leading to the sanity check failing. Moving a bracket should fix this.

---
 drivers/pci/pcie/aspm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/pci/pcie/aspm.c +1 -1
index 9a7c9e1..851f5b8 100644
@@ -527,7 +527,7 @@ static int pcie_aspm_sanity_check(struct pci_dev *pdev)
 		 */
 		pci_read_config_dword(child_dev, child_pos + PCI_EXP_DEVCAP,
 			&reg32);
-		if (!(reg32 & PCI_EXP_DEVCAP_RBER && !aspm_force)) {
+		if (!(reg32 & PCI_EXP_DEVCAP_RBER) && !aspm_force) {
 			printk("Pre-1.1 PCIe device detected, "
 				"disable ASPM for %s. It can be enabled forcedly"
 				" with 'pcie_aspm=force'\n", pci_name(pdev));
#2 lore raw
Quoted 11 lines · Alan Cox

On Tue, 16 Sep 2008 14:27:13 +0100

Quoted 6 lines · Sitsofe Wheeler

From: Sitsofe Wheeler <[email protected]>

pcie_aspm=force did not work because aspm_force was being double negated leading to the sanity check failing. Moving a bracket should fix this.

Not sure if I already sent you a note, but this is queued up in my for-linus branch. I'll be sending Linus a pull request later today for it.

Thanks,
Jesse