Skip to contentSkip to conversation

x86: print DMI information in the oops trace

PATCH In review Arjan van de Ven 3 participants 3 messages Sep 16, 2008 – Sep 17, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: print DMI information in the oops trace

From: Arjan van de Ven <[email protected]>
Subject: [PATCH] x86: print DMI information in the oops trace

in order to diagnose hard system specific issues, it's useful to have the system name in the oops (as provided by DMI)

---
 arch/x86/kernel/process_32.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)
arch/x86/kernel/process_32.c +8 -2
index 4eb2159..d9f34cf 100644
@@ -37,6 +37,7 @@
 #include <linux/tick.h>
 #include <linux/percpu.h>
 #include <linux/prctl.h>
+#include <linux/dmi.h>
 
 #include <asm/uaccess.h>
 #include <asm/pgtable.h>
@@ -127,6 +128,7 @@ void __show_regs(struct pt_regs *regs, int all)
 	unsigned long d0, d1, d2, d3, d6, d7;
 	unsigned long sp;
 	unsigned short ss, gs;
+	const char *board;
 
 	if (user_mode_vm(regs)) {
 		sp = regs->sp;
@@ -139,11 +141,15 @@ void __show_regs(struct pt_regs *regs, int all)
 	}
 
 	printk("\n");
-	printk("Pid: %d, comm: %s %s (%s %.*s)\n",
+
+	board = dmi_get_system_info(DMI_PRODUCT_NAME);
+	if (!board)
+		board = "";
+	printk("Pid: %d, comm: %s %s (%s %.*s) %s\n",
 			task_pid_nr(current), current->comm,
 			print_tainted(), init_utsname()->release,
 			(int)strcspn(init_utsname()->version, " "),
-			init_utsname()->version);
+			init_utsname()->version, board);
 
 	printk("EIP: %04x:[<%08lx>] EFLAGS: %08lx CPU: %d\n",
 			(u16)regs->cs, regs->ip, regs->flags,
Signature · 7 lines
1.5.5.1


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
#1 lore raw
Quoted 7 lines · Arjan van de Ven

From: Arjan van de Ven <[email protected]>
Subject: [PATCH] x86: print DMI information in the oops trace

in order to diagnose hard system specific issues, it's useful to have the system name in the oops (as provided by DMI)

good idea - applied to tip/x86/debug, thanks Arjan.

Ingo

#2 lore raw
In reply to Arjan van de Ven
Quoted 10 lines · Arjan van de Ven

From: Arjan van de Ven <[email protected]>
Subject: [PATCH] x86: print DMI information in the oops trace

in order to diagnose hard system specific issues, it's useful to have the system name in the oops (as provided by DMI)

---
 arch/x86/kernel/process_32.c |   10 ++++++++--

Not on 64-bit too?

J

Quoted 41 lines
 1 files changed, 8 insertions(+), 2 deletions(-)
arch/x86/kernel/process_32.c +8 -2
index 4eb2159..d9f34cf 100644
@@ -37,6 +37,7 @@
 #include <linux/tick.h>
 #include <linux/percpu.h>
 #include <linux/prctl.h>
+#include <linux/dmi.h>
 
 #include <asm/uaccess.h>
 #include <asm/pgtable.h>
@@ -127,6 +128,7 @@ void __show_regs(struct pt_regs *regs, int all)
 	unsigned long d0, d1, d2, d3, d6, d7;
 	unsigned long sp;
 	unsigned short ss, gs;
+	const char *board;
 
 	if (user_mode_vm(regs)) {
 		sp = regs->sp;
@@ -139,11 +141,15 @@ void __show_regs(struct pt_regs *regs, int all)
 	}
 
 	printk("\n");
-	printk("Pid: %d, comm: %s %s (%s %.*s)\n",
+
+	board = dmi_get_system_info(DMI_PRODUCT_NAME);
+	if (!board)
+		board = "";
+	printk("Pid: %d, comm: %s %s (%s %.*s) %s\n",
 			task_pid_nr(current), current->comm,
 			print_tainted(), init_utsname()->release,
 			(int)strcspn(init_utsname()->version, " "),
-			init_utsname()->version);
+			init_utsname()->version, board);
 
 	printk("EIP: %04x:[<%08lx>] EFLAGS: %08lx CPU: %d\n",
 			(u16)regs->cs, regs->ip, regs->flags,