Skip to contentSkip to conversation

Please pull git://www.denx.de/git/u-boot-ppc4xx.git

U-Boot Stefan Roese 2 participants 5 messages Sep 16, 2008 – Sep 22, 2008

lore
Share & tools
lore
#0 lore raw

The following changes since commit c0d2f87d6c450128b88e73eea715fa3654f65b6c:
Wolfgang Denk (1):

        Prepare v2008.10-rc2

are available in the git repository at:

git://www.denx.de/git/u-boot-ppc4xx.git master

Victor Gallardo (1):
ppc4xx: Fix DDR2 auto calibration on Kilauea 600MHz (200MHz PLB)

 board/amcc/kilauea/kilauea.c        |   31 +++++++++++++++++++++++++++++++
 cpu/ppc4xx/4xx_ibm_ddr2_autocalib.c |    5 -----
 include/asm-ppc/ppc4xx-sdram.h      |    6 ++++++
 3 files changed, 37 insertions(+), 5 deletions(-)
#1 lore raw

Dear Stefan Roese,

Quoted 10 lines · In message <[email protected]> you wrote:

The following changes since commit c0d2f87d6c450128b88e73eea715fa3654f65b6c:
Wolfgang Denk (1):

        Prepare v2008.10-rc2

are available in the git repository at:

git://www.denx.de/git/u-boot-ppc4xx.git master

Victor Gallardo (1):
ppc4xx: Fix DDR2 auto calibration on Kilauea 600MHz (200MHz PLB)

I'm not really happy abouthtis. AS I understand, this is just a temporary patch including a workaround for aproblem that is not yet understood.

We are not under preassure yet in terms of release schedule.

Wouldn't it be better to delay this until we have the final patch without such a workaround?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The number  of  Unix  installations  has  grown  to  10,  with  more
expected."    - The Unix Programmer's Manual, 2nd Edition, June, 1972
#2 lore raw

Hi Wolfgang,

Quoted 4 lines · Wolfgang Denk
Quoted 4 lines

The following changes since commit c0d2f87d6c450128b88e73eea715fa3654f65b6c: Wolfgang Denk (1):

        Prepare v2008.10-rc2
Quoted 8 lines
Quoted 6 lines

are available in the git repository at:

git://www.denx.de/git/u-boot-ppc4xx.git master

Victor Gallardo (1):
ppc4xx: Fix DDR2 auto calibration on Kilauea 600MHz (200MHz PLB)

I'm not really happy abouthtis.

I'm not either.

Quoted 3 lines

AS I understand, this is just a
temporary patch including a workaround for aproblem that is not yet understood.

Correct.

Quoted 1 line

We are not under preassure yet in terms of release schedule.

AMCC wants to ship the new 600MHz boards. This version at least works compared to the current version which turns those boards into bricks, since it doesn't bootup into the U-Boot prompt. So it definitely is an improvement.

Quoted 2 lines

Wouldn't it be better to delay this until we have the final patch without such a workaround?

I was hesitating here too, but I think its good enough to include this patch now. It definitely is a temporary fix and I hope that AMCC provides a "better", final patch that fixes this problem soon. Problem is that nobody knows how long this could take.

But in the end it's your call. If you reject this patch as is, then I'll revert it in my repository.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#3 lore raw

Dear Stefan,

Quoted 5 lines · in message <[email protected]> you wrote:
Quoted 4 lines

AS I understand, this is just a
temporary patch including a workaround for aproblem that is not yet understood.

Quoted 7 lines

Correct.

Quoted 1 line

We are not under preassure yet in terms of release schedule.

AMCC wants to ship the new 600MHz boards. This version at least works compared to the current version which turns those boards into bricks, since it doesn't bootup into the U-Boot prompt. So it definitely is an improvement.

We agree on this. But I would rather wait for a real fix for mainline. In the meantime, you could keep this workaround in a separate branch of your ppc4xx repository.

Quoted 4 lines

I was hesitating here too, but I think its good enough to include this patch now. It definitely is a temporary fix and I hope that AMCC provides a "better", final patch that fixes this problem soon. Problem is that nobody knows how long this could take.

I hope AMCC can still make it for the next release - we still have nearly 3 weeks plus some time for final testing.

Quoted 2 lines

But in the end it's your call. If you reject this patch as is, then I'll revert it in my repository.

Please revert it in the master branch. Thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quantum Mechanics is God's version of "Trust me."
#4 lore raw

Hi Wolfgang,

Quoted 8 lines · Wolfgang Denk
Quoted 4 lines

AMCC wants to ship the new 600MHz boards. This version at least works compared to the current version which turns those boards into bricks, since it doesn't bootup into the U-Boot prompt. So it definitely is an improvement.

We agree on this. But I would rather wait for a real fix for mainline. In the meantime, you could keep this workaround in a separate branch of your ppc4xx repository.

This could be an option. I'll talk with AMCC about this.

Quoted 5 lines
Quoted 4 lines

I was hesitating here too, but I think its good enough to include this patch now. It definitely is a temporary fix and I hope that AMCC provides a "better", final patch that fixes this problem soon. Problem is that nobody knows how long this could take.

Quoted 7 lines

I hope AMCC can still make it for the next release - we still have nearly 3 weeks plus some time for final testing.

Quoted 2 lines

But in the end it's your call. If you reject this patch as is, then I'll revert it in my repository.

Please revert it in the master branch. Thanks.

Done.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================