Skip to contentSkip to conversation

ALSA: hda - Fix ALC662 DAC mixer mutes also for auto config model

PATCH Applied Herton Ronaldo Krzesinski 2 participants 2 messages Sep 18, 2008 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda - Fix ALC662 DAC mixer mutes also for auto config model

In previous change "[ALSA] hda-codec - Fix ALC662 DAC mixer mutes", I missed to fix the mixer mute switches also for the auto config model of ALC662. Now mute for mixer items "Front", "Surround", "Center" and "LFE" when available will work too with "auto" model.

sound/pci/hda/patch_realtek.c renamed from sound/pci/hda/patch_realtek.c.orig +7 -7
diff -p -up linux-2.6.27/sound/pci/hda/patch_realtek.c.orig linux-2.6.27/sound/pci/hda/patch_realtek.c
@@ -15975,15 +15975,15 @@ static int alc662_auto_create_multi_out_
 							      HDA_OUTPUT));
 			if (err < 0)
 				return err;
-			err = add_control(spec, ALC_CTL_BIND_MUTE,
+			err = add_control(spec, ALC_CTL_WIDGET_MUTE,
 					  "Center Playback Switch",
-					  HDA_COMPOSE_AMP_VAL(nid, 1, 2,
+					  HDA_COMPOSE_AMP_VAL(0x0e, 1, 0,
 							      HDA_INPUT));
 			if (err < 0)
 				return err;
-			err = add_control(spec, ALC_CTL_BIND_MUTE,
+			err = add_control(spec, ALC_CTL_WIDGET_MUTE,
 					  "LFE Playback Switch",
-					  HDA_COMPOSE_AMP_VAL(nid, 2, 2,
+					  HDA_COMPOSE_AMP_VAL(0x0e, 2, 0,
 							      HDA_INPUT));
 			if (err < 0)
 				return err;
@@ -15995,9 +15995,9 @@ static int alc662_auto_create_multi_out_
 			if (err < 0)
 				return err;
 			sprintf(name, "%s Playback Switch", chname[i]);
-			err = add_control(spec, ALC_CTL_BIND_MUTE, name,
-					  HDA_COMPOSE_AMP_VAL(nid, 3, 2,
-							      HDA_INPUT));
+			err = add_control(spec, ALC_CTL_WIDGET_MUTE, name,
+				HDA_COMPOSE_AMP_VAL(alc880_idx_to_mixer(i),
+						    3, 0, HDA_INPUT));
 			if (err < 0)
 				return err;
 		}
Signature · 2 lines
[]'s
Herton
Applied
#1 lore raw

At Thu, 18 Sep 2008 16:41:49 -0300,

Quoted 7 lines · Herton Ronaldo Krzesinski

In previous change "[ALSA] hda-codec - Fix ALC662 DAC mixer mutes", I missed to fix the mixer mute switches also for the auto config model of ALC662. Now mute for mixer items "Front", "Surround", "Center" and "LFE" when available will work too with "auto" model.

Applied. Thanks.

Takashi