usb: Fix compile warning of r8a66597-hcd
PATCH 1/1 usb: Fix compile warning of r8a66597-hcd
--- drivers/usb/r8a66597-hcd.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/usb/r8a66597-hcd.c +0 -0
@@ -530,7 +530,7 @@ static int check_usb_device_connecting(struct
r8a66597 *r8a66597)
/* based on usb_ohci.c */
#define min_t(type, x, y) \
- ({ type __x = (x); type __y = (y); __x < __y ? __x: __y; })
+ ({ type __x = (x); type __y = (y); __x < __y ? __x : __y; })
/*-------------------------------------------------------------------------*
* Virtual Root Hub *-------------------------------------------------------------------------*/
@@ -794,7 +794,7 @@ static int r8a66597_submit_rh_msg(struct usb_device *dev, unsigned long pipe,
case RH_SET_CONFIGURATION:
break;
default:
- dbg("unsupported root hub command");
+ R8A66597_DPRINT("unsupported root hub command");
stat = USB_ST_STALLED;
}
Signature · 1 line
1.5.6.3
Markus Klotzbücher
AppliedPATCH 1/1 usb: Fix compile warning of r8a66597-hcd
Dear Nobuhiro,
drivers/usb/r8a66597-hcd.c
Quoted 7 lines · Nobuhiro Iwamatsu
Signed-off-by Nobuhiro Iwamatsu <[email protected]>--- drivers/usb/r8a66597-hcd.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/usb/r8a66597-hcd.c +0
-0
Your patch is line wrapped.
drivers/usb/r8a66597-hcd.c static int check_usb_device_connecting(struct · line 530
Quoted 4 lines
drivers/usb/r8a66597-hcd.c +0
-0@@ -530,7 +530,7 @@ static int check_usb_device_connecting(struct r8a66597 *r8a66597)
and here.
Quoted 9 lines
drivers/usb/r8a66597-hcd.c +1
-1/* based on usb_ohci.c */ #define min_t (type, x, y) \ - ({ type __x = (x); type __y = (y); __x < __y ? __x: __y; }) + ({ type __x = (x); type __y = (y); __x < __y ? __x : __y; })/*-------------------------------------------------------------------------* * Virtual Root Hub *-------------------------------------------------------------------------*/
drivers/usb/r8a66597-hcd.c static int r8a66597_submit_rh_msg(struct · line 800
Quoted 8 lines
drivers/usb/r8a66597-hcd.c +1
-1@@ -794,7 +794,7 @@ static int r8a66597_submit_rh_msg(struct usb_device *dev, unsigned long pipe, case RH_SET_CONFIGURATION: break;default : -dbg ("unsupported root hub command" ); +R8A66597_DPRINT ("unsupported root hub command" ); stat =USB_ST_STALLED ; }
Please fix your mailer next time.
Applied to USB repo.
Thanks!
Markus
Signature · 3 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de")
PATCH 1/1 usb: Fix compile warning of r8a66597-hcd
In reply to Nobuhiro IwamatsuDear "Nobuhiro Iwamatsu",
drivers/usb/r8a66597-hcd.c static int check_usb_device_connecting(struct · line 530
Quoted 11 lines · In message <[email protected]> you…
Signed-off-by Nobuhiro Iwamatsu <[email protected]>--- drivers/usb/r8a66597-hcd.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/usb/r8a66597-hcd.c +0
-0@@ -530,7 +530,7 @@ static int check_usb_device_connecting(struct r8a66597 *r8a66597)
^^^^^^^^^^^^^^^^^^^^^^
drivers/usb/r8a66597-hcd.c static int r8a66597_submit_rh_msg(struct · line 794
Quoted 9 lines
drivers/usb/r8a66597-hcd.c +1
-1/* based on usb_ohci.c */ #define min_t (type, x, y) \ - ({ type __x = (x); type __y = (y); __x < __y ? __x: __y; }) + ({ type __x = (x); type __y = (y); __x < __y ? __x : __y; })/*-------------------------------------------------------------------------* * Virtual Root Hub *-------------------------------------------------------------------------*/ @@ -794,7 +794,7 @@ static int r8a66597_submit_rh_msg(struct usb_device *dev, unsigned long pipe,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Just for the record: your patches are corrupted because your mailer wraps long lines.
Please fix.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If the facts don't fit the theory, change the facts.
-- Albert Einstein