Skip to contentSkip to conversation

progear_bl: use platform_device_register_simple()

PATCH In review Akinobu Mita 2 participants 3 messages Sep 21, 2008 – Nov 28, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 progear_bl: use platform_device_register_simple()

This change also fixes error handling when platform_device_alloc() fails. (When platform_device_alloc() failed, it returns error without unregistering progearbl_driver)

Cc Marcin Juszkiewicz <[email protected]>
Cc Richard Purdie <[email protected]>
---
 drivers/video/backlight/progear_bl.c |   20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)
drivers/video/backlight/progear_bl.c +8 -12
Index: 2.6-git/drivers/video/backlight/progear_bl.c
===================================================================
@@ -119,20 +119,16 @@ static int __init progearbl_init(void)
 {
 	int ret = platform_driver_register(&progearbl_driver);
 
-	if (!ret) {
-		progearbl_device = platform_device_alloc("progear-bl", -1);
-		if (!progearbl_device)
-			return -ENOMEM;
-
-		ret = platform_device_add(progearbl_device);
-
-		if (ret) {
-			platform_device_put(progearbl_device);
-			platform_driver_unregister(&progearbl_driver);
-		}
+	if (ret)
+		return ret;
+	progearbl_device = platform_device_register_simple("progear-bl", -1,
+								NULL, 0);
+	if (IS_ERR(progearbl_device)) {
+		platform_driver_unregister(&progearbl_driver);
+		return PTR_ERR(progearbl_device);
 	}
 
-	return ret;
+	return 0;
 }
 
 static void __exit progearbl_exit(void)
#1 lore raw
Quoted 3 lines · On Sunday 21 of September 2008 16:38:29 Akinobu Mita wrote:

This change also fixes error handling when platform_device_alloc() fails. (When platform_device_alloc() failed, it returns error without unregistering progearbl_driver)

I do not have this hardware working now so will not be able to test it during next month or two.

Quoted 3 lines
Cc Marcin Juszkiewicz <[email protected]>
Cc Richard Purdie <[email protected]>
Acked-by on v1 1/1
#2 lore raw
In reply to Akinobu Mita

Sunday 21 of September 2008 16:38:29 Akinobu Mita napisał(a):

Quoted 7 lines

This change also fixes error handling when platform_device_alloc() fails. (When platform_device_alloc() failed, it returns error without unregistering progearbl_driver)

Cc Marcin Juszkiewicz <[email protected]>
Cc Richard Purdie <[email protected]>
Quoted 27 lines
---
 drivers/video/backlight/progear_bl.c |   20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

Index: 2.6-git/drivers/video/backlight/progear_bl.c
===================================================================

drivers/video/backlight/progear_bl.c +3 -12
@@ -119,20 +119,16 @@ static int __init progearbl_init(void)
 {
 	int ret = platform_driver_register(&progearbl_driver);
 
-	if (!ret) {
-		progearbl_device = platform_device_alloc("progear-bl", -1);
-		if (!progearbl_device)
-			return -ENOMEM;
-
-		ret = platform_device_add(progearbl_device);
-
-		if (ret) {
-			platform_device_put(progearbl_device);
-			platform_driver_unregister(&progearbl_driver);
-		}
+	if (ret)
+		return ret;
+	progearbl_device = platform_device_register_simple("progear-bl",
-1, +								NULL, 0);

drivers/video/backlight/progear_bl.c static int __init progearbl_init(void) · line 134

Quoted 10 lines
drivers/video/backlight/progear_bl.c +4 -1
+	if (IS_ERR(progearbl_device)) {
+		platform_driver_unregister(&progearbl_driver);
+		return PTR_ERR(progearbl_device);
 	}
 
-	return ret;
+	return 0;
 }
 
 static void __exit progearbl_exit(void)

Regards,

Signature · 3 lines
JID:      [email protected]
Website:  http://blog.haerwu.biz/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz