Skip to contentSkip to conversation

acer-wmi: add error checks in module_init

PATCH Carlos Corbacho 3 participants 6 messages Sep 21, 2008 – Sep 22, 2008

lore
Share & tools
lore
#0 lore raw
Quoted 1 line · On Sunday 21 September 2008 15:29:59 Akinobu Mita wrote:

This patch fixes these bugs by using platform_device_register_simple()

[Adding Greg KH to CC - 2nd time lucky...]

Last I heard, platform_device_register_simple() was in the process of being deprecated and then slated for future removal. Has this changed?

-Carlos

Signature · 3 lines
E-Mail: [email protected]
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
#1 lore raw
Quoted 7 lines · Carlos Corbacho
Quoted 1 line · On Sunday 21 September 2008 15:29:59 Akinobu Mita wrote:

This patch fixes these bugs by using platform_device_register_simple()

[Adding Greg KH to CC - 2nd time lucky...]

Last I heard, platform_device_register_simple() was in the process of being deprecated and then slated for future removal. Has this changed?

I didn't know about that plan. But if platform_device_alloc/add is more preferable API than platform_device_register_simple(). I'll amend those patches and resend them.

#2 lore raw

(I forget to CC)

2008/9/22 Akinobu Mita <[email protected]>:

Quoted 12 lines · Carlos Corbacho
Quoted 7 lines · On Sunday 21 September 2008 15:29:59 Akinobu Mita wrote:
Quoted 1 line

This patch fixes these bugs by using platform_device_register_simple()

[Adding Greg KH to CC - 2nd time lucky...]

Last I heard, platform_device_register_simple() was in the process of being deprecated and then slated for future removal. Has this changed?

I didn't know about that plan. But if platform_device_alloc/add is more preferable API than platform_device_register_simple(). I'll amend those patches and resend them.

The number of platform_device_register_simple() is not decreasing. So I think the removal plan for platform_device_register_simple is not started (yet).

grep -r platform_device_register_simple 2.6.XX | wc -l

2.6.20: 64
2.6.21: 77
2.6.22: 66
2.6.23: 76
2.6.24: 80
2.6.25: 87
2.6.26: 83
2.6.27-rc7: 88

#3 lore raw
In reply to Carlos Corbacho
Quoted 7 lines · Carlos Corbacho
Quoted 1 line · On Sunday 21 September 2008 15:29:59 Akinobu Mita wrote:

This patch fixes these bugs by using platform_device_register_simple()

[Adding Greg KH to CC - 2nd time lucky...]

Last I heard, platform_device_register_simple() was in the process of being deprecated and then slated for future removal. Has this changed?

I don't recall this, but someone else might have stated it a while ago.

sorry,

greg k-h

#4 lore raw
Quoted 10 lines · On Monday 22 September 2008 16:59:49 Greg KH wrote:
Quoted 7 lines · Carlos Corbacho
Quoted 1 line · On Sunday 21 September 2008 15:29:59 Akinobu Mita wrote:

This patch fixes these bugs by using platform_device_register_simple()

[Adding Greg KH to CC - 2nd time lucky...]

Last I heard, platform_device_register_simple() was in the process of being deprecated and then slated for future removal. Has this changed?

I don't recall this, but someone else might have stated it a while ago.

http://linux.derkeiler.com/Mailing-Lists/Kernel/2006-04/msg02070.html

This was dated a while ago, but has anything changed since then?

-Carlos

Signature · 3 lines
E-Mail: [email protected]
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
#5 lore raw
Quoted 7 lines · Carlos Corbacho
Quoted 6 lines · On Monday 22 September 2008 16:59:49 Greg KH wrote:
Quoted 5 lines · Carlos Corbacho
Quoted 1 line · On Sunday 21 September 2008 15:29:59 Akinobu Mita wrote:

This patch fixes these bugs by using platform_device_register_simple()

[Adding Greg KH to CC - 2nd time lucky...]

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Last I heard, platform_device_register_simple() was in the process of being deprecated and then slated for future removal. Has this changed?

I don't recall this, but someone else might have stated it a while ago.

http://linux.derkeiler.com/Mailing-Lists/Kernel/2006-04/msg02070.html

This was dated a while ago, but has anything changed since then?

Not that I know of, I just forgot about it :)

thanks,

greg k-h