Skip to contentSkip to conversation

Tracing/ftrace: Make nop tracer reset previous entries

PATCH In review Frédéric Weisbecker 3 participants 5 messages Sep 21, 2008 – Sep 22, 2008 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Tracing/ftrace: Make nop tracer reset previous entries

If nop tracer is selected, some old entries from the previous tracer could still be enqueued. Tracing have to be reset.

---

kernel/trace/trace_nop.c +0 -1
diff -rup linux-2.6-tip (2)/kernel/trace/trace_nop.c linux-2.6-tip/kernel/trace/trace_nop.c
@@ -25,8 +25,12 @@ static void stop_nop_trace(struct trace_
 }
 
 
 
 static void nop_trace_init(struct trace_array *tr)
 
-{
 

- ctx_trace = tr;

+{
+ int cpu;

+ ctx_trace = tr;
+
+ for_each_online_cpu(cpu)

+ tracing_reset(tr->data[cpu]);

if (tr->ctrl)

start_nop_trace(tr);

#1 lore raw

your patch seems corrupted.
please check again your e-mail client settings.

Quoted 37 lines

If nop tracer is selected, some old entries from the previous tracer could still be enqueued. Tracing have to be reset.

---
diff -rup linux-2.6-tip (2)/kernel/trace/trace_nop.c linux-2.6-tip/kernel/trace/trace_nop.c

kernel/trace/trace_nop.c +6 -3
@@ -25,8 +25,12 @@ static void stop_nop_trace(struct trace_
 }
 
 
 
 static void nop_trace_init(struct trace_array *tr)
 
-{
 
-	ctx_trace = tr;
 
+{
+	int cpu;
 
+	ctx_trace = tr;
+
+	for_each_online_cpu(cpu)
 
+		tracing_reset(tr->data[cpu]);
 
 
 
 	if (tr->ctrl)
 
 		start_nop_trace(tr);
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 2 lines · KOSAKI Motohiro

your patch seems corrupted.
please check again your e-mail client settings.

i fixed the extra newlines up and applied the patches to tip/tracing/ftrace, thanks Frédéric!

please check Documentation/email-clients.txt about details. There were two problems i saw: overlong lines in the commit description and extra 'double newlines' in the patch itself. (To get around gmail limitations you can send -tip patches as MIME attachments as well.)

Ingo

#3 lore raw

2008/9/22 Ingo Molnar <[email protected]>:

Quoted 9 lines · KOSAKI Motohiro
Quoted 3 lines

your patch seems corrupted.
please check again your e-mail client settings.

i fixed the extra newlines up and applied the patches to tip/tracing/ftrace, thanks Frédéric!

Quoted 7 lines

please check Documentation/email-clients.txt about details. There were two problems i saw: overlong lines in the commit description and extra 'double newlines' in the patch itself. (To get around gmail limitations you can send -tip patches as MIME attachments as well.)

Ingo

Oops. I'm really sorry about that. I was pretty convinced that my email client was well configured.
In the future I will first send myself the patches before any new submit to ensure they are not damaged...

Thanks.

#4 lore raw
Quoted 15 lines · Frédéric Weisbecker

2008/9/22 Ingo Molnar <[email protected]>:

Quoted 14 lines · KOSAKI Motohiro
Quoted 3 lines

your patch seems corrupted.
please check again your e-mail client settings.

i fixed the extra newlines up and applied the patches to tip/tracing/ftrace, thanks Frédéric!

please check Documentation/email-clients.txt about details. There were two problems i saw: overlong lines in the commit description and extra 'double newlines' in the patch itself. (To get around gmail limitations you can send -tip patches as MIME attachments as well.)

Quoted 7 lines
Quoted 2 lines

Ingo

Oops. I'm really sorry about that. I was pretty convinced that my email client was well configured.
In the future I will first send myself the patches before any new submit to ensure they are not damaged...

no harm was done really, we can cope. I'd suggest you do the send-yourself thing once now to check that your practices are OK.

Ingo