drivers/net/wan: Use DIV_ROUND_UP
Subsystems (2)
PATCH 6/8 drivers/net/wan: Use DIV_ROUND_UP
From: Julia Lawall <[email protected]>
The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) / (d)) but is perhaps more readable.
An extract of the semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@haskernel@
@@
#include <linux/kernel.h>
@depends on haskernel@
expression n,d;
@@
(
- (n + d - 1) / d
+ DIV_ROUND_UP(n,d)
|
- (n + (d - 1)) / d
+ DIV_ROUND_UP(n,d)
)
@depends on haskernel@
expression n,d;
@@
- DIV_ROUND_UP((n),d)
+ DIV_ROUND_UP(n,d)
@depends on haskernel@
expression n,d;
@@
- DIV_ROUND_UP(n,(d))
+ DIV_ROUND_UP(n,d)
// </smpl>
---
drivers/net/wan/sbni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wan/sbni.c renamed from drivers/net/wan/sbni.c~drivers-net-wan-use-div_round_up +1 -1
@@ -856,7 +856,7 @@ prepare_to_send( struct sk_buff *skb, len =SBNI_MIN_LEN ; nl->tx_buf_p = skb; - nl->tx_frameno = (len + nl->maxframe -1 ) / nl->maxframe; + nl->tx_frameno =DIV_ROUND_UP (len, nl->maxframe); nl->framelen = len < nl->maxframe ? len : nl->maxframe;outb (inb ( dev->base_addr +CSR0 ) |TR_REQ , dev->base_addr +CSR0 );
_
From: [email protected]
Date: Mon, 22 Sep 2008 14:50:42 -0700
Quoted 5 lines
The
kernel.hmacroDIV_ROUND_UPperforms the computation (((n) + (d) - 1) / (d)) but is perhaps more readable.An extract of the semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
...
Quoted 2 lines
Signed-off-by Julia Lawall <[email protected]>Signed-off-by Andrew Morton <[email protected]>
[ Why is Chas being CC:'d on WAN driver layer patches? He's the ATM
maintainer :-) ]
Applied to net-next-2.6, thanks.