Skip to contentSkip to conversation

Only register notifiers when the braille console is used.

PATCH In review Samuel Thibault 3 participants 4 messages Sep 22, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Only register notifiers when the braille console is used.

Only register the braille driver VT and keyboard notifiers when the braille console is used. Avoids eating insert or backspace keys.

http://bugzilla.kernel.org/show_bug.cgi?id=11242

---
 drivers/accessibility/braille/braille_console.c |   13 ++++---------
 1 files changed, 4 insertions(+), 9 deletions(-)
drivers/accessibility/braille/braille_console.c +4 -9
index 0a5f6b2..d672cfe 100644
@@ -376,6 +376,8 @@ int braille_register_console(struct console *console, int index,
 	console->flags |= CON_ENABLED;
 	console->index = index;
 	braille_co = console;
+	register_keyboard_notifier(&keyboard_notifier_block);
+	register_vt_notifier(&vt_notifier_block);
 	return 0;
 }
 
@@ -383,15 +385,8 @@ int braille_unregister_console(struct console *console)
 {
 	if (braille_co != console)
 		return -EINVAL;
+	unregister_keyboard_notifier(&keyboard_notifier_block);
+	unregister_vt_notifier(&vt_notifier_block);
 	braille_co = NULL;
 	return 0;
 }
-
-static int __init braille_init(void)
-{
-	register_keyboard_notifier(&keyboard_notifier_block);
-	register_vt_notifier(&vt_notifier_block);
-	return 0;
-}
-
-console_initcall(braille_init);
Signature · 1 line
1.6.0.2
#1 lore raw
Quoted 7 lines · Samuel Thibault

Only register the braille driver VT and keyboard notifiers when the braille console is used. Avoids eating insert or backspace keys.

http://bugzilla.kernel.org/show_bug.cgi?id=11242

As this patch isn't upstream yet, if you want it to be included automatically in the next -stable release when it is added to Linus's tree, just add a:
Cc: stable <[email protected]>

to the signed-off-by: area. When it goes into Linus's tree, we will automatically get notified and it will then be added to the -stable tree with no additional work for you.

hope this helps,

greg k-h

#2 lore raw
In reply to Samuel Thibault
Quoted 7 lines · On Mon, 22 Sep 2008 23:40:31 +0200 Samuel Thibault…

Only register the braille driver VT and keyboard notifiers when the braille console is used. Avoids eating insert or backspace keys.

http://bugzilla.kernel.org/show_bug.cgi?id=11242

I have a suspision from your signoff trail that Pascal actually authored this patch. Is that correct?

If so, the authorship should have been tracked by putting his From:
line right at the top of the changelog.

Thanks.

#3 lore raw
Quoted 5 lines · Andrew Morton, le Mon 22 Sep 2008 16:36:21 -0700, a écrit :
Quoted 3 lines · On Mon, 22 Sep 2008 23:40:31 +0200 Samuel Thibault…

Only register the braille driver VT and keyboard notifiers when the braille console is used. Avoids eating insert or backspace keys.

Quoted 7 lines
Quoted 4 lines

http://bugzilla.kernel.org/show_bug.cgi?id=11242

I have a suspision from your signoff trail that Pascal actually authored this patch. Is that correct?

Err, yes.

Quoted 2 lines

If so, the authorship should have been tracked by putting his From:
line right at the top of the changelog.

Ah, sorry, I still haven't catched up with the new usages.

Samuel