Skip to contentSkip to conversation

x86: Add missing idle.h include to process_32.c

PATCH In review Rafael J. Wysocki 3 participants 7 messages Sep 23, 2008 – Sep 24, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: Add missing idle.h include to process_32.c

Hi,

This fixes a very recent compilation breakage on 32-bit x86.

Please apply.

Thanks,
Rafael

---
From: Rafael J. Wysocki <[email protected]>

x86: Add missing idle.h include to process_32.c

---
 arch/x86/kernel/process_32.c |    1 +
 1 file changed, 1 insertion(+)
arch/x86/kernel/process_32.c +1 -0
Index: linux-2.6/arch/x86/kernel/process_32.c
===================================================================
@@ -55,6 +55,7 @@
 #include <asm/tlbflush.h>
 #include <asm/cpu.h>
 #include <asm/kdebug.h>
+#include <asm/idle.h>
 
 asmlinkage void ret_from_fork(void) __asm__("ret_from_fork");
 
#1 lore raw
Quoted 3 lines · Rafael J. Wysocki

Hi,

This fixes a very recent compilation breakage on 32-bit x86.

the fix is queued up in tip/timers/urgent - sorry about that.

Ingo

#2 lore raw

[git pull] timers fixes

Linus,

Please pull the latest timers-fixes-for-linus git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git timers-fixes-for-linus

Thanks,

Ingo

------------------>
Marc Dionne (1):
x86: prevent stale state of c1e_mask across CPU offline/online, fix

 arch/x86/kernel/process_32.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/process_32.c +1 -0
index 4b3cfdf..31f40b2 100644
@@ -55,6 +55,7 @@
 #include <asm/tlbflush.h>
 #include <asm/cpu.h>
 #include <asm/kdebug.h>
+#include <asm/idle.h>
 
 asmlinkage void ret_from_fork(void) __asm__("ret_from_fork");
 
#3 lore raw

Re: [git pull] timers fixes

Quoted 6 lines · Ingo Molnar

Linus,

Please pull the latest timers-fixes-for-linus git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git timers-fixes-for-linus

Quoted 7 lines

Thanks,

Ingo

------------------>
Marc Dionne (1):
x86: prevent stale state of c1e_mask across CPU offline/online, fix

Is that all the changeset comment ? Am I the only one to find that totally useless ? Or is that the mail doesn't contain the actual comment, only the title followed by the patch ?

Cheers,
Ben.

Quoted 22 lines
 arch/x86/kernel/process_32.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/process_32.c +1 -1
index 4b3cfdf..31f40b2 100644
@@ -55,6 +55,7 @@
 #include <asm/tlbflush.h>
 #include <asm/cpu.h>
 #include <asm/kdebug.h>
+#include <asm/idle.h>
 
 asmlinkage void ret_from_fork(void) __asm__("ret_from_fork");
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#4 lore raw

Re: [git pull] timers fixes

Quoted 11 lines · Benjamin Herrenschmidt
Quoted 10 lines · Ingo Molnar

Linus,

Please pull the latest timers-fixes-for-linus git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git timers-fixes-for-linus

Thanks,

Ingo

Quoted 7 lines
Quoted 3 lines

------------------>
Marc Dionne (1):
x86: prevent stale state of c1e_mask across CPU offline/online, fix

Is that all the changeset comment ? Am I the only one to find that totally useless ? Or is that the mail doesn't contain the actual comment, only the title followed by the patch ?

yeah. The build error is something like:

arch/x86/kernel/process_32.c:78: warning: data definition has no type or storage class arch/x86/kernel/process_32.c:78: warning: type defaults to 'int' in declaration of 'c1e_remove_cpu' arch/x86/kernel/process_32.c:78: warning: parameter names (without types) in function declaration

Ingo

#5 lore raw

Re: [git pull] timers fixes

In reply to Benjamin Herrenschmidt
Quoted 11 lines · Benjamin Herrenschmidt
Quoted 10 lines · Ingo Molnar

Linus,

Please pull the latest timers-fixes-for-linus git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git timers-fixes-for-linus

Thanks,

Ingo

Quoted 7 lines
Quoted 3 lines

------------------>
Marc Dionne (1):
x86: prevent stale state of c1e_mask across CPU offline/online, fix

Is that all the changeset comment ? Am I the only one to find that totally useless ? Or is that the mail doesn't contain the actual comment, only the title followed by the patch ?

Allright, so in fact, it's more like the log doesn't match the patch in the email..

Ben.

Quoted 25 lines

Cheers,
Ben.

Quoted 22 lines
 arch/x86/kernel/process_32.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/process_32.c +1 -1
index 4b3cfdf..31f40b2 100644
@@ -55,6 +55,7 @@
 #include <asm/tlbflush.h>
 #include <asm/cpu.h>
 #include <asm/kdebug.h>
+#include <asm/idle.h>
 
 asmlinkage void ret_from_fork(void) __asm__("ret_from_fork");
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#6 lore raw

Re: [git pull] timers fixes

Quoted 16 lines · Benjamin Herrenschmidt
Quoted 15 lines · Benjamin Herrenschmidt
Quoted 13 lines · Ingo Molnar

Linus,

Please pull the latest timers-fixes-for-linus git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git timers-fixes-for-linus

Thanks,

Ingo

------------------>
Marc Dionne (1):
x86: prevent stale state of c1e_mask across CPU offline/online, fix

Quoted 6 lines
Quoted 3 lines

Is that all the changeset comment ? Am I the only one to find that totally useless ? Or is that the mail doesn't contain the actual comment, only the title followed by the patch ?

Allright, so in fact, it's more like the log doesn't match the patch in the email..

only because i already picked up a different submission at that time, and posted in this thread.

i picked up this one from lkml:

Subject: [PATCH] Fix build error introduced by commit 4faac97d44ac27bdbb010a9c3597401a8f89341f

see the full commit log below, it has all the details.

Ingo

------------>

Quoted 1 line

From 1eda81495a49a4ee91d8863b0a441a624375efea Mon Sep 17 00:00:00 2001

From: Marc Dionne <[email protected]>
Date: Tue, 23 Sep 2008 22:40:02 -0400
Subject: [PATCH] x86: prevent stale state of c1e_mask across CPU offline/online, fix

Fix build error introduced by commit 4faac97d44ac27 ("x86: prevent stale state of c1e_mask across CPU offline/online").

process_32.c needs to include idle.h to get the prototype for c1e_remove_cpu()

---
 arch/x86/kernel/process_32.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/process_32.c +1 -0
index 4b3cfdf..31f40b2 100644
@@ -55,6 +55,7 @@
 #include <asm/tlbflush.h>
 #include <asm/cpu.h>
 #include <asm/kdebug.h>
+#include <asm/idle.h>
 
 asmlinkage void ret_from_fork(void) __asm__("ret_from_fork");