alsa-plugins: Start PA event loop after we have created the context.
PATCH 1/1 alsa-plugins: Start PA event loop after we have created the context.
Heya!
We shouldn't be passing the main loop object to the pa_context while that loop is running and not locked. Push the main loop startup after we created the main loop.
--- pulse/pulse.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
pulse/pulse.c +3 -3
@@ -188,9 +188,6 @@ snd_pulse_t *pulse_new(void)if (!p->mainloop) goto fail; -if (pa_threaded_mainloop_start (p->mainloop) <0 ) - goto fail; -if (pa_get_binary_name (proc,sizeof (proc)))snprintf (buf,sizeof (buf),"ALSA plug-in [%s]" ,pa_path_get_filename (proc));
@@ -204,6 +201,9 @@ snd_pulse_t *pulse_new(void)pa_context_set_state_callback (p->context, context_state_cb, p); +if (pa_threaded_mainloop_start (p->mainloop) <0 ) + goto fail; +return p; fail:
Signature · 10 lines
1.6.0.1 Lennart -- Lennart Poettering Red Hat, Inc. lennart [at] poettering [dot] net ICQ# 11060553 http://0pointer.net/lennart/ GnuPG 0x1A015CC4
Takashi Iwai
AppliedAt Thu, 25 Sep 2008 21:01:22 +0200,
Quoted 6 lines · Lennart Poettering
Heya!
We shouldn't be passing the main loop object to the
pa_contextwhile that loop is running and not locked. Push the main loop startup after we created the main loop.
Applied all 4 patches now. Thanks.
Takashi