Skip to contentSkip to conversation

Tracepoints fix reentrancy

PATCH Applied Mathieu Desnoyers 2 participants 2 messages Sep 30, 2008 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Tracepoints fix reentrancy

The tracepoints had the same problem markers did have wrt reentrancy. Apply a similar fix using a rcu_barrier after each tracepoint mutex lock.

CC Ingo Molnar <[email protected]>
CC "Frank Ch. Eigler" <[email protected]>
CC Lai Jiangshan <[email protected]>
---
 kernel/tracepoint.c |    4 ++++
 1 file changed, 4 insertions(+)
kernel/tracepoint.c +4 -0
Index: linux-2.6-lttng/kernel/tracepoint.c
===================================================================
@@ -361,6 +361,8 @@ int tracepoint_probe_register(const char
 	mutex_lock(&tracepoints_mutex);
 	entry = get_tracepoint(name);
 	WARN_ON(!entry);
+	if (entry->rcu_pending)
+		rcu_barrier_sched();
 	tracepoint_entry_free_old(entry, old);
 end:
 	mutex_unlock(&tracepoints_mutex);
@@ -397,6 +399,8 @@ int tracepoint_probe_unregister(const ch
 	entry = get_tracepoint(name);
 	if (!entry)
 		goto end;
+	if (entry->rcu_pending)
+		rcu_barrier_sched();
 	tracepoint_entry_free_old(entry, old);
 	remove_tracepoint(name);	/* Ignore busy error message */
 	ret = 0;
Signature · 2 lines
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68