scsi: Disable advansys on ARM and MIPS
PATCH 1/1 scsi: Disable advansys on ARM and MIPS
Commit 9d511a4b29de6764931343d03e493f2e04df0271 ("advansys: Changes to work on parisc") removed the "depends on BROKEN || X86_32" line from advansys' Kconfig entry. Unfortunately, this led to compilation errors on ARM and MIPS (that are not related). Since nobody looked into this issue since I reported it in January 2008 and Russell King said that the driver is completely broken on ARM, let's undo some of the damage caused by the removal of the "BROKEN" Kconfig depends by disabling the driver on ARM and MIPS.
drivers/scsi/Kconfig +1 -0
@@ -523,6 +523,7 @@ tristate "AdvanSys SCSI support" depends on SCSI && VIRT_TO_BUS depends on ISA || EISA || PCI + depends on (!MIPS && !ARM) || BROKEN help This is a driver for all SCSI host adapters manufactured by AdvanSys. It is documented in the kernel source in
Signature · 2 lines
Martin Michlmayr http://www.cyrius.com/
Quoted 8 lines · Martin Michlmayr
Commit
9d511a4b29de6764931343d03e493f2e04df0271("advansys: Changes to work on parisc") removed the "depends on BROKEN ||X86_32" line from advansys'Kconfigentry. Unfortunately, this led to compilation errors on ARM and MIPS (that are not related). Since nobody looked into this issue since I reported it in January 2008 and Russell King said that the driver is completely broken on ARM, let's undo some of the damage caused by the removal of the "BROKEN"Kconfigdepends by disabling the driver on ARM and MIPS.
I'd still call it broken everywhere. People who really care about this driver should just help with the full dma api translation, if only by testing patches.
Quoted 3 lines · Christoph Hellwig
I'd still call it broken everywhere. People who really care about this driver should just help with the full dma api translation, if only by testing patches.
I don't have the hardware or care about the driver, but I care about the compilation errors on ARM and MIPS that were not there before willy's patch. Anyway, since you say it's broken, how about putting back in the original Kconfig depends and add parisc to the list.
I don't care which patch goes in, as long as the compilation error goes away.
From: Martin Michlmayr <[email protected]>
Subject: [PATCH] scsi: Enable advansys on x86_32 and parisc only
Commit 9d511a4b29de6764931343d03e493f2e04df0271 ("advansys: Changes to work on parisc") removed the "depends on BROKEN || X86_32" line from the advansys Kconfig entry. Unfortunately, this led to compilation errors on ARM and MIPS (that are not related). Nobody looked into this issue since I reported it in January 2008, but Russell King said that the driver is completely broken on ARM, and Christoph Hellwig calls it "broken everywhere". So let's put in the original depends on BROKEN and make the driver available on x86_32 and parisc.
drivers/scsi/Kconfig +1 -0
@@ -520,6 +520,7 @@ config SCSI_ADVANSYS tristate "AdvanSys SCSI support" depends on SCSI && VIRT_TO_BUS depends on ISA || EISA || PCI + depends on BROKEN || X86_32 || PARISC help This is a driver for all SCSI host adapters manufactured by AdvanSys. It is documented in the kernel source in
Signature · 2 lines
Martin Michlmayr http://www.cyrius.com/
Quoted 8 lines · Martin Michlmayr
Commit
9d511a4b29de6764931343d03e493f2e04df0271("advansys: Changes to work on parisc") removed the "depends on BROKEN ||X86_32" line from advansys'Kconfigentry. Unfortunately, this led to compilation errors on ARM and MIPS (that are not related). Since nobody looked into this issue since I reported it in January 2008 and Russell King said that the driver is completely broken on ARM, let's undo some of the damage caused by the removal of the "BROKEN"Kconfigdepends by disabling the driver on ARM and MIPS.
Huh? I've looked into it. ARM and MIPS provide half of an API but not the other half. These architectures are broken.
Signature · 4 lines
Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
Quoted 11 lines · Matthew Wilcox
Quoted 8 lines
Commit
9d511a4b29de6764931343d03e493f2e04df0271("advansys: Changes to work on parisc") removed the "depends on BROKEN ||X86_32" line from advansys'Kconfigentry. Unfortunately, this led to compilation errors on ARM and MIPS (that are not related). Since nobody looked into this issue since I reported it in January 2008 and Russell King said that the driver is completely broken on ARM, let's undo some of the damage caused by the removal of the "BROKEN"Kconfigdepends by disabling the driver on ARM and MIPS.Huh? I've looked into it. ARM and MIPS provide half of an API but not the other half. These architectures are broken.
Maybe, but the point is that advansys was marked as BROKEN on !X86_32 before and now it's not, so the ARM/MIPS compilation errors show up and that's a regression. What you say is a good argument for my patch to disable advansys for ARM/MIPS in Kconfig.
Signature · 2 lines
Martin Michlmayr http://www.cyrius.com/
Quoted 8 lines · Martin Michlmayr
Quoted 2 lines · Matthew Wilcox
Huh? I've looked into it. ARM and MIPS provide half of an API but not the other half. These architectures are broken.
Maybe, but the point is that advansys was marked as BROKEN on !X86_32 before and now it's not, so the ARM/MIPS compilation errors show up and that's a regression. What you say is a good argument for my patch to disable advansys for ARM/MIPS in
Kconfig.
No, ARM and MIPS need to just add stub functions that do nothing.
Signature · 4 lines
Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."