OF: add fsl,mcu-mpc8349emitx to the exception list
Subsystems (2)
PATCH 1/2 OF: add fsl,mcu-mpc8349emitx to the exception list
of/base.c matches on the first (most specific) entries, which isn't quite practical but it was discussed[1] that this won't change.
The bindings specifies verbose information for the devices, but it doesn't fit in the I2C ID's 20 characters limit. The limit won't change[2], and the bindings won't change either as they're correct.
So we have to put an exception for the MPC8349E-mITX-compatible MCUs.
[1] http://www.mail-archive.com/[email protected]/msg21196.html
[2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html
--- drivers/of/base.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/of/base.c +1 -1
@@ -410,7 +410,7 @@ struct of_modalias_table {char *modalias; };static struct of_modalias_table of_modalias_table[] = { -/* Empty for now; add entries as needed */ + {"fsl,mcu-mpc8349emitx" ,"mcu-mpc8349emitx" }, };/**
Signature · 1 line
1.5.6.3
Quoted 10 lines · Anton Vorontsov
of/base.cmatches on the first (most specific) entries, which isn't quite practical but it was discussed[1] that this won't change.The bindings specifies verbose information for the devices, but it doesn't fit in the I2C ID's 20 characters limit. The limit won't change[2], and the bindings won't change either as they're correct.
So we have to put an exception for the MPC8349E-mITX-compatible MCUs.
Quoted 7 lines
[1] http://www.mail-archive.com/[email protected]/msg21196.html
[2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.htmlSigned-off-by Anton Vorontsov <[email protected]>--- drivers/of/base.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Any issues with this or the second patch? Can we merge them?
Thanks,
Quoted 15 lines
drivers/of/base.c +1
-1@@ -410,7 +410,7 @@ struct of_modalias_table {char *modalias; };static struct of_modalias_table of_modalias_table[] = { -/* Empty for now; add entries as needed */ + {"fsl,mcu-mpc8349emitx" ,"mcu-mpc8349emitx" }, };/** Signature · 1 line
1.5.6.3
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
Hi Anton,
Quoted 14 lines · Anton Vorontsov
Quoted 13 lines · Anton Vorontsov
of/base.cmatches on the first (most specific) entries, which isn't quite practical but it was discussed[1] that this won't change.The bindings specifies verbose information for the devices, but it doesn't fit in the I2C ID's 20 characters limit. The limit won't change[2], and the bindings won't change either as they're correct.
So we have to put an exception for the MPC8349E-mITX-compatible MCUs.
[1] http://www.mail-archive.com/[email protected]/msg21196.html
[2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html
Quoted 6 lines
Quoted 4 lines
Signed-off-by Anton Vorontsov <[email protected]>--- drivers/of/base.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)Any issues with this or the second patch? Can we merge them?
I do not have the time to review these patches (and, honestly, have no interest in them.) So I will not merge them but I have no objection to them being merged by somebody else.
Signature · 1 line
Jean Delvare
Quoted 22 lines · Jean Delvare
Hi Anton,
Quoted 19 lines · Anton Vorontsov
Quoted 17 lines · Anton Vorontsov
of/base.cmatches on the first (most specific) entries, which isn't quite practical but it was discussed[1] that this won't change.The bindings specifies verbose information for the devices, but it doesn't fit in the I2C ID's 20 characters limit. The limit won't change[2], and the bindings won't change either as they're correct.
So we have to put an exception for the MPC8349E-mITX-compatible MCUs.
[1] http://www.mail-archive.com/[email protected]/msg21196.html
[2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.htmlSigned-off-by Anton Vorontsov <[email protected]>--- drivers/of/base.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 5 lines
Quoted 1 line
Any issues with this or the second patch? Can we merge them?
I do not have the time to review these patches (and, honestly, have no interest in them.) So I will not merge them but I have no objection to them being merged by somebody else.
Ok, thanks for the sincerity.. ;-)
Kumar, could you pick up the two patches via the patchworks?
[1/2] OF: add fsl,mcu-mpc8349emitx to the exception list
http://patchwork.ozlabs.org/patch/1105/
[2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver
http://patchwork.ozlabs.org/patch/1106/
Or should I resend them to you? Or should I resend them to Andrew?
Thanks,
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
On Wed, Oct 01, 2008 at 03:39:48PM +0400, Anton Vorontsov wrote:
[...]
Quoted 10 lines
Quoted 5 lines
Quoted 1 line
Any issues with this or the second patch? Can we merge them?
I do not have the time to review these patches (and, honestly, have no interest in them.) So I will not merge them but I have no objection to them being merged by somebody else.
Ok, thanks for the sincerity.. ;-)
Kumar, could you pick up the two patches via the patchworks?
Quoted 7 lines
[1/2] OF: add fsl,mcu-mpc8349emitx to the exception list
http://patchwork.ozlabs.org/patch/1105/[2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver
http://patchwork.ozlabs.org/patch/1106/Or should I resend them to you? Or should I resend them to Andrew?
Ping?
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
A message that is not in the archive (sent off-list or not yet received): 20081006172831.GA27233-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org
Re: [PATCH 1/2] OF: add fsl, mcu-mpc8349emitx to the exception list
Quoted 15 lines · Anton Vorontsov
On Wed, Oct 01, 2008 at 03:39:48PM +0400, Anton Vorontsov wrote:
[...]Quoted 13 lines
Quoted 5 lines
Quoted 1 line
Any issues with this or the second patch? Can we merge them?
I do not have the time to review these patches (and, honestly, have no interest in them.) So I will not merge them but I have no objection to them being merged by somebody else.
Ok, thanks for the sincerity.. ;-)
Kumar, could you pick up the two patches via the patchworks?
[1/2] OF: add fsl,mcu-mpc8349emitx to the exception list
http://patchwork.ozlabs.org/patch/1105/
Since I've been involved with the i2c of bindings, I can pick this one up.
Quoted 2 lines
Quoted 2 lines
[2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver
http://patchwork.ozlabs.org/patch/1106/
But I'm not involved enough with this one, so it should go through kumar.
g.
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
Quoted 11 lines · Grant Likely
Quoted 10 lines · Anton Vorontsov
On Wed, Oct 01, 2008 at 03:39:48PM +0400, Anton Vorontsov wrote:
[...]Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Any issues with this or the second patch? Can we merge them?
I do not have the time to review these patches (and, honestly, have no interest in them.) So I will not merge them but I have no objection to them being merged by somebody else.
Ok, thanks for the sincerity.. ;-)
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Kumar, could you pick up the two patches via the patchworks?
[1/2] OF: add fsl,mcu-mpc8349emitx to the exception list
http://patchwork.ozlabs.org/patch/1105/Since I've been involved with the i2c of bindings, I can pick this one up.
Much appreciated, thanks!
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
[2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver
http://patchwork.ozlabs.org/patch/1106/But I'm not involved enough with this one, so it should go through kumar.
That's fine, the first and second patches could go separate trees since it won't break the build.
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
Kumar Gala
AppliedQuoted 10 lines · Anton Vorontsov
of/base.cmatches on the first (most specific) entries, which isn't quite practical but it was discussed[1] that this won't change.The bindings specifies verbose information for the devices, but it doesn't fit in the I2C ID's 20 characters limit. The limit won't change[2], and the bindings won't change either as they're correct.
So we have to put an exception for the MPC8349E-mITX-compatible MCUs.
Quoted 7 lines
[1] http://www.mail-archive.com/[email protected]/msg21196.html
[2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.htmlSigned-off-by Anton Vorontsov <[email protected]>---
drivers/of/base.c| 2 +-1 files changed, 1 insertions(+), 1 deletions(-)
applied.
- k