Skip to contentSkip to conversation

suspend/resume for ATI Mobility Radeon RV350

PATCH In review Wolfgang Kroener 2 participants 5 messages Sep 30, 2008 – Jan 9, 2009 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 suspend/resume for ATI Mobility Radeon RV350

Hi,
I have a ATI Mobility Radeon RV350 and similar problems with radeonfb described in http://kernel.org/doc/Documentation/power/s2ram.txt
Adding the device to radeon_workaround_list solves the Problem. Please accept the following patch:

--8<--

video/aty/radeon_pm.c renamed from video/aty/radeon_pm.c.orig +3 -0
@@ -89,6 +89,9 @@
 	BUGFIX("Acer Aspire 2010",
 	       PCI_VENDOR_ID_AI, 0x0061,
 	       radeon_pm_off, radeon_reinitialize_M10),
+	BUGFIX("Acer Travelmate 290D/292LMi",
+	       PCI_VENDOR_ID_AI, 0x005a,
+	       radeon_pm_off, radeon_reinitialize_M10),
 	{ .ident = NULL }
 };
 

-->8--
Kind regards,
Wolfgang

P. S. please CC me, because I'm not subscribed to the lkml

#1 lore raw
Quoted 5 lines · Wolfgang Kroener

Hi,
I have a ATI Mobility Radeon RV350 and similar problems with radeonfb described in http://kernel.org/doc/Documentation/power/s2ram.txt
Adding the device to radeon_workaround_list solves the Problem. Please accept the following patch:

Can you resend it with a proper Signed-off-by: line ? Thanks !

Cheers,
Ben.

Quoted 18 lines

--8<--

video/aty/radeon_pm.c renamed from video/aty/radeon_pm.c.orig +3 -1
@@ -89,6 +89,9 @@
 	BUGFIX("Acer Aspire 2010",
 	       PCI_VENDOR_ID_AI, 0x0061,
 	       radeon_pm_off, radeon_reinitialize_M10),
+	BUGFIX("Acer Travelmate 290D/292LMi",
+	       PCI_VENDOR_ID_AI, 0x005a,
+	       radeon_pm_off, radeon_reinitialize_M10),
 	{ .ident = NULL }
 };
 
-->8--

Kind regards,
Wolfgang

P. S. please CC me, because I'm not subscribed to the lkml

#2 lore raw

Hi,

Quoted 1 line · Benjamin Herrenschmidt

Can you resend it with a proper Signed-off-by: line ? Thanks !

I hope, that's right.
Kind regards,
Wolfgang

Signature · 21 lines
radeonfb suspend/resume for Acer Travelmate 29X

This patch adds suspend/resume for the Acer Travelmate 290D/292LMi with
the following graphic-chip:
01:00.0 VGA compatible controller [0300]: ATI Technologies Inc RV350
[Mobility Radeon 9600 M10] [1002:4e50] (prog-if 00 [VGA controller])
	Subsystem: Acer Incorporated [ALI] TravelMate 290 [1025:005a]
	Flags: bus master, 66MHz, medium devsel, latency 128, IRQ 10
	Memory at a8000000 (32-bit, prefetchable) [size=128M]
	I/O ports at c100 [size=256]
	Memory at e0010000 (32-bit, non-prefetchable) [size=64K]
	[virtual] Expansion ROM at a0000000 [disabled] [size=128K]
	Capabilities: [58] AGP version 2.0
	Capabilities: [50] Power Management version 2
	Kernel driver in use: radeonfb
	Kernel modules: radeonfb

Signed-off-by: Wolfgang Kroener <[email protected]>
---
 drivers/video/aty/radeon_pm.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/video/aty/radeon_pm.c +3 -0
index 675abda..5e4b2da 100644
@@ -89,6 +89,9 @@ static struct radeon_device_id radeon_workaround_list[] = {
 	BUGFIX("Acer Aspire 2010",
 	       PCI_VENDOR_ID_AI, 0x0061,
 	       radeon_pm_off, radeon_reinitialize_M10),
+	BUGFIX("Acer Travelmate 290D/292LMi",
+	       PCI_VENDOR_ID_AI, 0x005a,
+	       radeon_pm_off, radeon_reinitialize_M10),
 	{ .ident = NULL }
 };
 
#3 lore raw
In reply to Benjamin Herrenschmidt

Hi,

Quoted 1 line · Benjamin Herrenschmidt

Can you resend it with a proper Signed-off-by: line ? Thanks !

I think the mail (http://lkml.org/lkml/2008/10/1/134) got lost somewhere, so I try again:

radeonfb suspend/resume for Acer Travelmate 29X

This patch adds suspend/resume for the Acer Travelmate 290D/292LMi with the following graphic-chip:
01:00.0 VGA compatible controller [0300]: ATI Technologies Inc RV350 [Mobility Radeon 9600 M10] [1002:4e50] (prog-if 00 [VGA controller])

	Subsystem: Acer Incorporated [ALI] TravelMate 290 [1025:005a]
	Flags: bus master, 66MHz, medium devsel, latency 128, IRQ 10
	Memory at a8000000 (32-bit, prefetchable) [size=128M]
	I/O ports at c100 [size=256]
	Memory at e0010000 (32-bit, non-prefetchable) [size=64K]
	[virtual] Expansion ROM at a0000000 [disabled] [size=128K]
	Capabilities: [58] AGP version 2.0
	Capabilities: [50] Power Management version 2
	Kernel driver in use: radeonfb
	Kernel modules: radeonfb
---
 drivers/video/aty/radeon_pm.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/video/aty/radeon_pm.c +3 -0
index 675abda..5e4b2da 100644
@@ -89,6 +89,9 @@ static struct radeon_device_id radeon_workaround_list[] = {
 	BUGFIX("Acer Aspire 2010",
 	       PCI_VENDOR_ID_AI, 0x0061,
 	       radeon_pm_off, radeon_reinitialize_M10),
+	BUGFIX("Acer Travelmate 290D/292LMi",
+	       PCI_VENDOR_ID_AI, 0x005a,
+	       radeon_pm_off, radeon_reinitialize_M10),
 	{ .ident = NULL }
 };
 
Signature · 1 line
1.5.6.5
#4 lore raw

Re: Bug#506964: [PATCH] suspend/resume for ATI Mobility Radeon RV350

Quoted 6 lines · Wolfgang Kroener

Hi,

Quoted 1 line · Benjamin Herrenschmidt

Can you resend it with a proper Signed-off-by: line ? Thanks !

I think the mail (http://lkml.org/lkml/2008/10/1/134) got lost somewhere, so I try again:

Fell through the cracks along with some of my own radeonfb patches :-)

Thanks for reminding.

Cheers,
Ben.

Quoted 42 lines

radeonfb suspend/resume for Acer Travelmate 29X

This patch adds suspend/resume for the Acer Travelmate 290D/292LMi with the following graphic-chip:
01:00.0 VGA compatible controller [0300]: ATI Technologies Inc RV350 [Mobility Radeon 9600 M10] [1002:4e50] (prog-if 00 [VGA controller])

	Subsystem: Acer Incorporated [ALI] TravelMate 290 [1025:005a]
	Flags: bus master, 66MHz, medium devsel, latency 128, IRQ 10
	Memory at a8000000 (32-bit, prefetchable) [size=128M]
	I/O ports at c100 [size=256]
	Memory at e0010000 (32-bit, non-prefetchable) [size=64K]
	[virtual] Expansion ROM at a0000000 [disabled] [size=128K]
	Capabilities: [58] AGP version 2.0
	Capabilities: [50] Power Management version 2
	Kernel driver in use: radeonfb
	Kernel modules: radeonfb
---
 drivers/video/aty/radeon_pm.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/video/aty/radeon_pm.c +3 -0
index 675abda..5e4b2da 100644
@@ -89,6 +89,9 @@ static struct radeon_device_id radeon_workaround_list[] = {
 	BUGFIX("Acer Aspire 2010",
 	       PCI_VENDOR_ID_AI, 0x0061,
 	       radeon_pm_off, radeon_reinitialize_M10),
+	BUGFIX("Acer Travelmate 290D/292LMi",
+	       PCI_VENDOR_ID_AI, 0x005a,
+	       radeon_pm_off, radeon_reinitialize_M10),
 	{ .ident = NULL }
 };
 
Signature · 1 line
1.5.6.5