Skip to contentSkip to conversation

cpuset doesn't seem to be so const

PATCH Applied Frederic Weisbecker 2 participants 2 messages Oct 3, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpuset doesn't seem to be so const

This fixes a warning on last -tip:

kernel/cpuset.c: Dans la fonction «scan_for_empty_cpusets» :
kernel/cpuset.c:1932: attention : passing argument 1 of «list_add_tail» discards qualifiers from pointer target type

Actually the struct cpuset *root passed in parameter to scan_for_empty_cpusets is not supposed to be const since an entry is added on the tail of its list. Just correct the qualifier.

---
 kernel/cpuset.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/cpuset.c +1 -1
index 827cd9a..eab7bd6 100644
@@ -1921,7 +1921,7 @@ static void remove_tasks_in_empty_cpuset(struct cpuset *cs)
  * that has tasks along with an empty 'mems'.  But if we did see such
  * a cpuset, we'd handle it just like we do if its 'cpus' was empty.
  */
-static void scan_for_empty_cpusets(const struct cpuset *root)
+static void scan_for_empty_cpusets(struct cpuset *root)
 {
 	LIST_HEAD(queue);
 	struct cpuset *cp;	/* scans cpusets being updated */
Applied
#1 lore raw
Quoted 10 lines · Frederic Weisbecker

This fixes a warning on last -tip:

kernel/cpuset.c: Dans la fonction «scan_for_empty_cpusets» :
kernel/cpuset.c:1932: attention : passing argument 1 of «list_add_tail» discards qualifiers from pointer target type

Actually the struct cpuset *root passed in parameter to scan_for_empty_cpusets is not supposed to be const since an entry is added on the tail of its list. Just correct the qualifier.

applied to tip/sched/cpusets, thanks Frederic!

Ingo