Skip to contentSkip to conversation

mISDN didn't define af_family_key_strings et al.

DISCUSSION Eric Paris 2 participants 3 messages Oct 9, 2008

lore
Share & tools
lore

Eric Paris

author
#0 lore raw

I see that recently AF_ISDN was added to the kernel but I don't see them having updated af_family_key_strings[] found in net/core/sock.c. I'm adding a new one myself and caught a NULL entry toward the end of the array. My assumption is that isdn is using the sk_lock-AF_MAX entry instead of their own.

As an aside it was nice having such a clean explosion when I didn't add my own. Are the AF_MAX entries in those arrays really needed? If we dropped it altogether would others (like myself and the isdn people) who forgot to add their own get nice explosions with no other problems?

-Eric

#1 lore raw

From: Eric Paris <[email protected]>
Date: Wed, 08 Oct 2008 20:27:29 -0400

Quoted 5 lines

I see that recently AF_ISDN was added to the kernel but I don't see them having updated af_family_key_strings[] found in net/core/sock.c. I'm adding a new one myself and caught a NULL entry toward the end of the array. My assumption is that isdn is using the sk_lock-AF_MAX entry instead of their own.

This has been fixed in net-next-2.6 for a few weeks.

net/core/sock.c:
"sk_lock-AF_RXRPC" , "sk_lock-AF_ISDN" , "sk_lock-AF_PHONET" ,

author
#2 lore raw
Quoted 9 lines · David Miller

From: Eric Paris <[email protected]>
Date: Wed, 08 Oct 2008 20:27:29 -0400

Quoted 5 lines

I see that recently AF_ISDN was added to the kernel but I don't see them having updated af_family_key_strings[] found in net/core/sock.c. I'm adding a new one myself and caught a NULL entry toward the end of the array. My assumption is that isdn is using the sk_lock-AF_MAX entry instead of their own.

Quoted 4 lines

This has been fixed in net-next-2.6 for a few weeks.

net/core/sock.c:
"sk_lock-AF_RXRPC" , "sk_lock-AF_ISDN" , "sk_lock-AF_PHONET" ,

Thanks dave. Didn't see it in Linus's or the ISDN trees. Didn't even think to look in net-next....

-Eric