Skip to contentSkip to conversation

phy_device: Interrupt number 0 is valid

PATCH In review Paulius Zaleckas 2 participants 4 messages Oct 8, 2008 – Oct 9, 2008

Subsystems (3)
Networking Network drivers Ethernet PHY
lore
Share & tools
lore

Paulius Zaleckas

author
#0 lore raw

PATCH 1/1 phy_device: Interrupt number 0 is valid

If interrupt number 0(valid interrupt number) will be passed as phy interrupt it should be used. In current situation even phy polling will not work since PHY_POLL = -1

Signed-off-by Paulius Zaleckas <[email protected]>
drivers/net/phy/phy_device.c +2 -2
Index: linux-2.6/drivers/net/phy/phy_device.c
===================================================================
@@ -285,7 +285,7 @@ struct phy_device * phy_connect(struct n
 
 	phy_start_machine(phydev, NULL);
 
-	if (phydev->irq > 0)
+	if (phydev->irq >= 0)
 		phy_start_interrupts(phydev);
 
 	return phydev;

@@ -298,7 +298,7 @@ EXPORT_SYMBOL(phy_connect);
  */
 void phy_disconnect(struct phy_device *phydev)
 {
-	if (phydev->irq > 0)
+	if (phydev->irq >= 0)
 		phy_stop_interrupts(phydev);
 
 	phy_stop_machine(phydev);
maintainer
#1 lore raw

From: Paulius Zaleckas <[email protected]>
Date: Wed, 08 Oct 2008 15:16:32 +0300

Quoted 5 lines

If interrupt number 0(valid interrupt number) will be passed as phy interrupt it should be used. In current situation even phy polling will not work since PHY_POLL = -1

Signed-off-by Paulius Zaleckas <[email protected]>

In the Linux kernel, interrupt number 0 is defined as not valid.

author
#2 lore raw
Quoted 10 lines · David Miller

From: Paulius Zaleckas <[email protected]>
Date: Wed, 08 Oct 2008 15:16:32 +0300

Quoted 5 lines

If interrupt number 0(valid interrupt number) will be passed as phy interrupt it should be used. In current situation even phy polling will not work since PHY_POLL = -1

Signed-off-by Paulius Zaleckas <[email protected]>

In the Linux kernel, interrupt number 0 is defined as not valid.

Where it is defined as not valid?
Maybe it is not valid under x86, but it is valid at least on ARM for sure.
Anyway if interrupt 0 is not valid then request_irq() will fail and PHY_POLL will be used.

maintainer
#3 lore raw

From: Paulius Zaleckas <[email protected]>
Date: Thu, 09 Oct 2008 10:05:03 +0300

Quoted 8 lines
Quoted 7 lines · David Miller

From: Paulius Zaleckas <[email protected]>
Date: Wed, 08 Oct 2008 15:16:32 +0300

Quoted 4 lines

If interrupt number 0(valid interrupt number) will be passed as phy interrupt it should be used. In current situation even phy polling will not work since PHY_POLL = -1

Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Paulius Zaleckas <[email protected]>

In the Linux kernel, interrupt number 0 is defined as not valid.

Where it is defined as not valid?
Maybe it is not valid under x86, but it is valid at least on ARM for sure.

There are many tests in the kernel that explicitly assume that IRQ zero is not valid.

And architectures should make amends to adhere to this convention, even if physically IRQ 0 is meaningful for them.